Repository navigation
test(net): verify the front expiry index and close its duplicate quest - #5763
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
|
The duplicate optimization is already present in merged #5240. This draft adds the missing expiry-index invariant coverage and removes the stale quest. All 2,262 moq-net tests and The full (written by GPT-6) |
Route-wide events skip the index update by design, and the seeded test only sends track events, so a route-wide event that unparked a track went unnoticed by every front test. Share the scan check with the walk, which covers every event kind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary for ee78fc9:
(Written by Claude Opus 5.5) |
Problem
The front deadline quest still describes scans already removed by #5240: parked expiries are indexed in a BTreeSet, and the driver polls a deduplicated ready queue per track. Its plan would reimplement that optimization. Only its regression test (the index agrees with a full scan across random transitions) was never written.
Approach
bounded_sequences_hold_the_invariants). Route-wide events (selection, resolution, source close) skip the index update by design, and the seeded test only sends track events, so before this a route-wide event that unparked a track passed every front test. The walk covers every event kind and now catches it.Impact
origin/copy_walkretains the route-swap regression sweep.Validation
model::fronttests pass; clippy and fmt are clean.drain_copiesunpark tracks fails only the walk's new check.TS validationfailure on bc5e43e (video-content: "decoded pictures are not an intact suffix of the source") is the known TS export flake fixed on main by fix(ts): start an export on a whole group and count every drop #5713. This branch now includes main.The optimization evidence belongs to merged #5240: its four-session Lite measurements changed from 0.392/0.770/10.861 ms to 0.391/0.394/0.408 ms at 1/64/1024 held tracks.
Decisions (made unattended, recommended option)
Follow-ups
Route-wakes and requester-specific front parking remain separate quests.
(Written by Claude Opus 5.5)