Repository navigation
fix(ci): get the Nightly workloads green - #5841
Conversation
|
Outcome: draft. Nightly workloads that failed in run 38897397428 are fixed locally where reproducible and probed on hosted runners where not, plus two later breaks (moq-uring no-default-features, Firefox/WebKit media). Open: the moq-gst macOS (Written by Claude Opus 5.5) |
|
Iterated with the maintainer's recommended choices: the formula test now checks that the plugin exists and links (Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3c6010f to
06869a8
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c6010fe5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -81,6 +81,8 @@ harness_begin() { | |||
| root="${root%/}" | |||
| [[ -n "${MOQ_TEST_RUNS:-}" ]] || root="$root/moq-test-$(id -u)" | |||
| mkdir -p "$root" | |||
| # Harnesses change directory after this, so a relative root would move under them. | |||
| root=$(cd "$root" && pwd) | |||
There was a problem hiding this comment.
When MOQ_TEST_RUNS is relative and the caller exports a CDPATH containing a directory with the same name, cd "$root" resolves to that directory instead of the one just created by mkdir; Bash also prints the resolved directory, so the command substitution captures both that output and pwd, leaving root with two newline-separated paths and causing mktemp to fail. Resolve the explicitly created path without applying CDPATH.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed, fixed in c48229e: CDPATH='' cd --. Checked with a CDPATH holding a same-named directory.
(Written by Claude Opus 5.5)
|
Rebased onto main (conflicts in (Written by Claude Opus 5.5) |
…seline workloads - Bump rustls to 0.23.46 (RUSTSEC-2026-0346..0349) and allow uniffi-bindgen's UniFFI fork as a git source; drop the ignore for an advisory no crate matches. - Gate moq-hls's build_inits like its siblings so the no-default-features test build compiles, and allow moq-mux's catalog State variant gap that only --all-features clippy sees. - Typecheck every js/net bench, which caught lite-varint and forward drifting from their APIs. - Resolve a relative MOQ_TEST_RUNS once in harness_begin, before a harness changes directory, so wasm-baseline's relay log lands where it reads it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The send-group adapters name quic types unconditionally, so the no-default-features check in the Nightly features workload fails. Gate them on the feature, and allow the worker and socket helpers only quic uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n media QA - perf's DWARF unwinding on the SVE-capable ARM runner requests the SVE VG register, which the kernel refuses for the software context-switches event. The same recording opens on the x86 runner. - Playwright validates Firefox and WebKit libraries with the dev shell's Nix ldd, which can't see the apt-installed ones, and refuses browsers that launch fine. Skip that check in the media-engines job. - Narrow the quest to the moq-gst formula hang, which needs a decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing it gst-inspect-1.0 1.28.8 hangs at startup inside brew test's sandbox on the headless macOS runner, even for --version with no plugin involved. Assert the plugin exists and links libgstreamer-1.0; the release build's smoke step already loads it into GStreamer outside the sandbox. The quest is complete, so delete it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
06869a8 to
c48229e
Compare
|
Merge summary: repairs the Nightly workloads that failed on 2026-10-16 (Audit, Features plus the later moq-uring break, JS benchmarks, browser backend baseline, relay lock-wait profile, moq-gst macOS formula) and the new Firefox/WebKit media rows. Decisions settled by the maintainer: the formula test checks the plugin's GStreamer link instead of running (Written by Claude Opus 5.5) |
Repairs every workload that failed in Nightly run 38897397428 (b4eab0d), except those owned by
quest/m0/release-link.md(Linux release builds, gst .deb/.rpm) andquest/m0/ci/platform-windows-drill.md. Also covers two that broke later.Changes
deny.tomldidn't allow thekixelated/uniffi-rsgit sourcemoq-hlsbuild_initswas#[cfg(feature = "server")]but tests call itcfg_attr(..., allow(dead_code))its siblings use--all-featuresclippy:large_enum_variantonmoq-muxcatalogStateallowwith a reason, matching the crate's other state enumsmain)moq-uring's transport namequictypes unconditionally, so--no-default-featuresstopped compilingquic; also silence the pre-existing dead-code warnings with the samecfg_attrlite-varint.tsmissedDatagram.decode'stimedargument.js/net/bench/tsconfig.jsonlisted only 7 of 18 benches, so the PR that added the argument never typechecked this filetimed, and typecheckbench/*.ts. That also caughtforward.tsmissinggoaway.harness_beginkept a relativeMOQ_TEST_RUNS, andwasm/run.shthen changes directoryharness_begin(fixes every harness). Added a regression test toharness.test.sh, whichjust test harnessruns in interop CI. It fails without the fix.gst-inspect-1.0hangs at startup insidebrew test's sandbox on the headless runner (GStreamer 1.28.8), with or without our pluginlibgstreamer-1.0, instead of runninggst-inspect-1.0--call-graph dwarfrequests the SVEVGregister (sample_regs_user0x4001ffffffff) on the SVE-capable ARM runner. The kernel refuses it for the softwarecontext-switchesevent (EOPNOTSUPP).ubuntu-24.04(x86). A new per-entryrunnermatrix key defaults to ARM. Note added tobench/README.md.lddonPATH. In the dev shell that is Nix glibc'sldd, which can't see the apt-installed libraries, so it reports evenlibglibas missing.PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS=1on that stepThis completes and deletes
quest/m0/ci/nightly-green.md.Evidence
cargo deny checkandjust rs features(the full recipe) pass, as dojust check,bun run checkinjs/net, and thelite-varintandforwardbenches.harness.test.shpasses, and fails againstmain'sharness.sh.just test wasm-baselinelocally: the run directory now resolves totarget/test/wasm-backend/..., and the relay logs land there. Chromium can't launch on this NixOS host, so the browser half of the run is unverified until Nightly.moq-gstdry run dispatched on this branch (run 39000627149):Build tarball (aarch64-apple-darwin)passes, includingTest Homebrew formula against tarballwith the new formula test. The.deb/.rpmjobs fail on the known zigbuild link error thatquest/m0/release-link.mdowns.ubuntu-24.04-arm: plain-c 1,--switch-events,-k monotonic,-m 2M, and--call-graph fpall open. Any--call-graph dwarffails.ubuntu-24.04: the full bench command records.ubuntu-24.04-arm: with systemldd, Chromium and WebKit launch. With Nix'sldd, WebKit is refused. With Nix'slddand validation skipped, WebKit 26.6 launches.Decisions
Settled by the maintainer (2026-10-17, recommended options).
brew testhangs.gst-inspect-1.0 --version.gst-inspect-1.0hangs at startup inside Homebrew's test sandbox. The last green run had GStreamer 1.28.6 on macOS 26 image 20260907; the first red one had 1.28.8 on image 20261013.sandbox-execwith only LaunchServices denied.gst-inspect-1.0call from the formula'stest doand assert the plugin exists and linkslibgstreamer-1.0. The build job's unsandboxed smoke step already loadsmoqsinkandmoqsrc.brew testonly insh/gh/gst-formula.py, leaving the formula unchanged.ubuntu-24.04(x86). This is the smallest change that keeps the smoke test. Its Rust cache is keyed by arch, so this job builds cold.sched:sched_switchtracepoint, which needs tracefs permissions the runner doesn't grant.Impact
Public API: none. Wire: none. CI-only, plus test, bench, and
cfgchanges.Follow-ups
mainyet (relay shard sweep,rs send-depth). No quest tracks this once this PR merges.VGbased on a hardware event, which then breaks software-event DWARF sampling.harness_envstill records a relativeMOQ_TEST_RUNSin the printed rerun command.Quest:
quest/m0/ci/nightly-green.md(deleted).(Written by Claude Opus 5.5)
🤖 Generated with Claude Code