Repository navigation
Conversation
…them wait_issued and wait_served serve only renewal_reaches_every_worker, which needs Linux and _quic. Elsewhere they were dead code, and just check, which denies warnings, failed on macOS for any change that includes moq-relay. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The epoch-anchor quest's co-start test: two peered test relays (moq_relay::test_relay_peered), one importer each under one epoch, started together. Both stay live, both catalogs carry the same root clock, and every frame the second relay serves matches the first's timestamp and payload. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing this. #5967 removed (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
quest/m2/epoch-anchor.mdlists among its tests "a co-start across two clustered relays leaves both live and byte-identical". The existing epoch test,importers_sharing_an_epoch_publish_identical_timestamps, runs both importers through one relay, one after the other. So nothing yet starts two importers at once on two relays that each hear the other's route under the same epoch.Approach
moq_relay::test_relay_peered(url, fingerprint)(behindtest-support): a test relay that dials another as its static cluster peer, pinning its certificate.test_relaynow shares its config and bind with it.importers_co_started_across_a_cluster_publish_one_timeline:moq import ts --epochprocesses start together, one per relay, fed the clip whole and from a third of the way in.Consumer::local) gives its own importer's broadcast. Both inputs end before either track is read, since a relay may resume a subscription on its peer's same-epoch route, which ends only with the other input.acme/tests.rs:wait_issuedandwait_servedtake thecfgof the one test that calls them. On macOS they were dead code, andjust check(which denies warnings) failed on any change that includesmoq-relay.Impact
Tests only, plus one new item behind
test-support. The test takes about 11 s locally.Alternatives
Follow-ups
The quest's other open items: catalog fields derived from an importer's own history (jitter, peak-held bitrate, top frame rate), and the successor epoch.
(Written by Claude Opus 5.5)