Skip to content

fix(video): propagate the Windows resize plan's error - #5966

Merged
kixelated merged 1 commit into
mainfrom
fix/video-windows-resize-plan
Oct 19, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/video-windows-resize-plan

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

#5808 made Plan::resize return Result<Plan, Error>, but the cfg(windows) Texture::resize in rs/moq-video/src/frame.rs still passed it straight to process, so moq-video no longer compiles on Windows:

error[E0308]: mismatched types
  --> rs\moq-video\src\frame.rs:2329:55
   expected `Plan`, found `Result<Plan, Error>`

The Linux gate skips that code, and Platform's Windows job only runs in the merge queue when the diff selects moq-video, so it first surfaced in #5919's merge group (Platform run 39287133263, Windows job 118177303188). This adds the missing ?.

Public API and wire impact

None.

Checks

  • cargo check --target x86_64-pc-windows-gnu -p moq-video (the flake's rust-overlay 1.98.1 with the windows-gnu std): fails on main with the error above, passes here. Also passes with --all-targets --features capture. CI's Windows job uses MSVC, so the merge queue's Platform run stays the authoritative gate.
  • just check: passes.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

#5808 made Plan::resize fallible, but the cfg(windows) Texture::resize still
passed its Result straight to process, so moq-video stopped compiling on
Windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:08:18.755791Z d0ad1ee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 19, 2026
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 707d7bb4-27ec-41ff-8329-bc313120fb77
📥 Commits

Reviewing files that changed from the base of the PR and between 8380595 and d0ad1ee.

📒 Files selected for processing: 1
  • rs/moq-video/src/frame.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Merged via the queue into main with commit 2e1ec2e Oct 19, 2026
9 checks passed
@kixelated
kixelated deleted the fix/video-windows-resize-plan branch October 19, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant