Repository navigation
fix(video): propagate the Windows resize plan's error - #5966
Conversation
#5808 made Plan::resize fallible, but the cfg(windows) Texture::resize still passed its Result straight to process, so moq-video stopped compiling on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
#5808 made
Plan::resizereturnResult<Plan, Error>, but thecfg(windows)Texture::resizeinrs/moq-video/src/frame.rsstill passed it straight toprocess, somoq-videono longer compiles on Windows:The Linux gate skips that code, and Platform's Windows job only runs in the merge queue when the diff selects
moq-video, so it first surfaced in #5919's merge group (Platform run 39287133263, Windows job 118177303188). This adds the missing?.Public API and wire impact
None.
Checks
cargo check --target x86_64-pc-windows-gnu -p moq-video(the flake's rust-overlay 1.98.1 with the windows-gnu std): fails on main with the error above, passes here. Also passes with--all-targets --features capture. CI's Windows job uses MSVC, so the merge queue's Platform run stays the authoritative gate.just check: passes.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code