Skip to content

fix(quic): query IPV6_V6ONLY only on IPv6 sockets - #6014

Merged
kixelated merged 3 commits into
moq-dev:mainfrom
zshenker:fix/quinn-17596dde
Oct 21, 2026
Merged

kixelated merged 3 commits into
moq-dev:mainfrom
zshenker:fix/quinn-17596dde

Conversation

@zshenker

Copy link
Copy Markdown
Contributor

Problem

On Windows, moq_sock::udp::UdpSocketState::new queries IPV6_V6ONLY on IPv4 sockets too, so endpoint creation fails if Winsock rejects that option for the IPv4 family.

Approach

  • Cherry-pick quinn-rs/quinn 17596dde with its author: only query it for AF_INET6.
  • List the commit under "Cherry-picked since the fork point".

Impact

  • Public API: none. Wire: none.
  • Windows only.

Alternatives

None.

Follow-ups

  • No regression test: upstream had no failing case and IPv4 sockets already pass on Windows CI, so this is defensive. just rs windows compiles it.

(Written by Claude Opus 5.5)

zerox80 and others added 2 commits October 19, 2026 16:09
Cherry-picked from quinn-rs/quinn 17596ddefb09dae895129520824055d0ac8da5d5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zshenker
zshenker marked this pull request as ready for review October 20, 2026 03:47
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 44da6303-c95d-43f3-8751-a3c94695d480
📥 Commits

Reviewing files that changed from the base of the PR and between bc64b9c and 94a3130.

📒 Files selected for processing: 2
  • rs/moq-quic/README.md
  • rs/moq-sock/src/udp/windows.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T14:46:33.036190Z 94a3130 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator

@codex review

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: fcc63131a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# Conflicts:
#	rs/moq-quic/README.md
@kixelated

Copy link
Copy Markdown
Collaborator

Merged main (now including #6015, #6013, and #6012) into this branch with a merge commit, 94a3130. The only conflict was the rs/moq-quic/README.md cherry-pick list; the 17596dde line now follows f74e6a8a in landing order. rs/moq-sock/src/udp/windows.rs merged cleanly.

just check passes locally (5491 + 516 + 223 tests). It does not compile windows.rs on Linux; the merge queue's Windows platform job covers that. An earlier local run hit export::redundant_importers_switch_through_bufferbloat_on_lite_07, a known flake on main that #6113 addresses and that this branch does not touch. Codex's last review of fcc6313 found no major issues, and nothing but the main merge and that README line has changed since.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 21, 2026 14:35
@kixelated
kixelated added this pull request to the merge queue Oct 21, 2026
Merged via the queue into moq-dev:main with commit fb28fa5 Oct 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants