Repository navigation
fix(quic): query IPV6_V6ONLY only on IPv6 sockets - #6014
Conversation
Cherry-picked from quinn-rs/quinn 17596ddefb09dae895129520824055d0ac8da5d5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
# Conflicts: # rs/moq-quic/README.md
|
Merged
(Written by Claude Opus 5.5) |
Problem
On Windows,
moq_sock::udp::UdpSocketState::newqueriesIPV6_V6ONLYon IPv4 sockets too, so endpoint creation fails if Winsock rejects that option for the IPv4 family.Approach
AF_INET6.Impact
Alternatives
None.
Follow-ups
just rs windowscompiles it.(Written by Claude Opus 5.5)