Repository navigation
docs: record compile-time audit baselines - #6022
Conversation
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
|
Recorded the clean dev/release and moq-net incremental baselines without changing production code. The final quest-only check passed at 16645bb. The measured net-edit full check remains an explicit exit 1: 7,608 native tests passed, then formatting rejected the discarded probe. Audit completion and any optimization choices remain open, so this PR stays draft. No merge or auto-merge was requested. (written by GPT-6.1-Sol) |
Job-level CI cost (cache hits, aws-lc-sys recompiles per cold job, both rustls backends in the gate, CI timings) belongs to the CI pipeline audit, and dependency deduplication to the dependency audit. Drop the overlapping aws-lc-sys follow-up, link both quests, and stop pointing at local-only scratch evidence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The m0 dependency audit finished in #6053; its recurring successor lives in m1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merging as a plan-only update to the compile-time audit; the quest stays open for the rest of the run.
(Written by Claude Opus 5.5) |
Align the audit with main's benchmark and smoke replans (#6081, #6046, #6022): the trend site is now the m0 regression table plus m2 benchmark sources, so the audit's m2/bench-site edits fold into m0/bench-site (the unprovisioned git.moq.dev HTTPS certificate) and its links retarget there. catalog-readers stays deleted, and the compile-time audit takes main's recorded baselines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
The compile-time audit had no recorded baselines or measured attribution.
Approach
Record default-member clean dev/release Cargo timings, exact-graph moq-net controls and a one-file incremental rebuild, dependency/proc-macro findings, and actual cache conditions. Keep the audit open; this PR changes only its plan and evidence.
The quiet dev build reported 4m32s. The explicitly shared-host release build reported 13m40s, dominated by final binary work. The trivial moq-net edit rebuilt in 8.025s. These are single observations, not before/after performance claims.
The quest now states its boundary with the CI pipeline audit: this audit owns per-crate cost in one build; job-level CI cost (cache keys and hits, aws-lc-sys recompiling per cold job, both rustls backends in the gate, CI
--timings) stays with the CI audit, and dependency deduplication with the dependency audit. The overlapping aws-lc-sys cache-miss follow-up was dropped, and the pointer to local-only.scratch/evidence was replaced with "re-measure", matching the CI audit.Decisions
Scope boundary with the CI pipeline audit (no maintainer input; recommended option picked):
PR state (maintainer picked ready):
just check, release attribution, fixing the bottlenecks, the m1 successor) lands on this branch per the quest's "fixes land in the run's PR"Impact
Validation
just check: exit 1 after 842.849s. Its native phase passed all 7,608 tests, with 31 skipped, but formatting rejected the disposable probe. The probe was restored; rustdoc and later feature checks were not reached. This is not a successful full-gate timing.quest checkpasses on the merged head. Main was merged in and the dependency audit link now points at its m1 successor, since the m0 run finished in moq-dev/moq#6053.just checkon the merged head fails only inbench/relay.test.py(test_a_foreign_listener_never_proves_relay_readinesstimes out at 15 s), which this PR does not touch; it fails the same way when run alone on the merged tree.Alternatives
Avoid changing crypto providers, supported defaults, or release LTO based only on noisy single-run timing. Proc macros were measured rather than assumed to dominate.
Follow-ups
The quest remains open for a successful ordinary net-edit full-check baseline, supported LLVM-lines/compiler attribution, and a measured decision on the largest costs.
cargo llvm-lineswas unavailable, andmbx explain --lasthad no recorded build; no cache-miss cause is claimed.Originally written by GPT-6.1-Sol.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code