Skip to content

docs: record compile-time audit baselines - #6022

Merged
kixelated merged 6 commits into
mainfrom
quest/m0/audit-compile-time
Oct 20, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m0/audit-compile-time

Conversation

@kixelated

@kixelated kixelated commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The compile-time audit had no recorded baselines or measured attribution.

Approach

Record default-member clean dev/release Cargo timings, exact-graph moq-net controls and a one-file incremental rebuild, dependency/proc-macro findings, and actual cache conditions. Keep the audit open; this PR changes only its plan and evidence.

The quiet dev build reported 4m32s. The explicitly shared-host release build reported 13m40s, dominated by final binary work. The trivial moq-net edit rebuilt in 8.025s. These are single observations, not before/after performance claims.

The quest now states its boundary with the CI pipeline audit: this audit owns per-crate cost in one build; job-level CI cost (cache keys and hits, aws-lc-sys recompiling per cold job, both rustls backends in the gate, CI --timings) stays with the CI audit, and dependency deduplication with the dependency audit. The overlapping aws-lc-sys cache-miss follow-up was dropped, and the pointer to local-only .scratch/ evidence was replaced with "re-measure", matching the CI audit.

Decisions

Scope boundary with the CI pipeline audit (no maintainer input; recommended option picked):

  • ✅ This audit owns per-crate build cost in one build; the CI audit owns job-level CI cost and caching (recommended: the CI audit already lists those levers, so two quests chasing them would conflict)
  • Keep the repeated aws-lc-sys native-compilation investigation here

PR state (maintainer picked ready):

  • Stay draft: the run's remaining work (a passing net-edit just check, release attribution, fixing the bottlenecks, the m1 successor) lands on this branch per the quest's "fixes land in the run's PR"
  • ✅ Mark ready as a plan-only update and finish the run in a later PR

Impact

  • Public API: none.
  • Wire: none.
  • No compiler, feature, profile, version, or global cache configuration changes.

Validation

  • Both clean builds and the standalone incremental/control builds passed.
  • Cache-enabled net-edit just check: exit 1 after 842.849s. Its native phase passed all 7,608 tests, with 31 skipped, but formatting rejected the disposable probe. The probe was restored; rustdoc and later feature checks were not reached. This is not a successful full-gate timing.
  • quest check passes on the merged head. Main was merged in and the dependency audit link now points at its m1 successor, since the m0 run finished in moq-dev/moq#6053.
  • Local just check on the merged head fails only in bench/relay.test.py (test_a_foreign_listener_never_proves_relay_readiness times out at 15 s), which this PR does not touch; it fails the same way when run alone on the merged tree.

Alternatives

Avoid changing crypto providers, supported defaults, or release LTO based only on noisy single-run timing. Proc macros were measured rather than assumed to dominate.

Follow-ups

The quest remains open for a successful ordinary net-edit full-check baseline, supported LLVM-lines/compiler attribution, and a measured decision on the largest costs. cargo llvm-lines was unavailable, and mbx explain --last had no recorded build; no cache-miss cause is claimed.

Originally written by GPT-6.1-Sol.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 19, 2026 16:24
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Recorded the clean dev/release and moq-net incremental baselines without changing production code. The final quest-only check passed at 16645bb. The measured net-edit full check remains an explicit exit 1: 7,608 native tests passed, then formatting rejected the discarded probe. Audit completion and any optimization choices remain open, so this PR stays draft. No merge or auto-merge was requested.

(written by GPT-6.1-Sol)

kixelated and others added 4 commits October 19, 2026 21:43
Job-level CI cost (cache hits, aws-lc-sys recompiles per cold job, both
rustls backends in the gate, CI timings) belongs to the CI pipeline
audit, and dependency deduplication to the dependency audit. Drop the
overlapping aws-lc-sys follow-up, link both quests, and stop pointing at
local-only scratch evidence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The m0 dependency audit finished in #6053; its recurring successor lives in m1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 20, 2026 20:06
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a3d29263-fa21-4542-b453-2c74c5733341
📥 Commits

Reviewing files that changed from the base of the PR and between 96d6b5b and fddd367.

📒 Files selected for processing: 1
  • quest/m0/audit-compile-time.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T20:09:01.391710Z fddd367 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging as a plan-only update to the compile-time audit; the quest stays open for the rest of the run.

  • Records clean dev/release Cargo baselines, the moq-net incremental control, and dependency/proc-macro findings as single observations.
  • Scopes this audit to per-crate build cost; job-level CI cost stays with the CI pipeline audit, and dependency deduplication with the m1 dependency audit (link repointed after quest(m0): finish the dependency and alternatives audit #6053).
  • quest check passes; Codex reviewed fddd367 with no findings.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 98700d3 Oct 20, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m0/audit-compile-time branch October 20, 2026 21:03
kixelated added a commit that referenced this pull request Oct 20, 2026
Align the audit with main's benchmark and smoke replans (#6081, #6046,
#6022): the trend site is now the m0 regression table plus m2 benchmark
sources, so the audit's m2/bench-site edits fold into m0/bench-site (the
unprovisioned git.moq.dev HTTPS certificate) and its links retarget there.
catalog-readers stays deleted, and the compile-time audit takes main's
recorded baselines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant