Repository navigation
fix(nix): select wasm-bindgen CLI from Cargo.lock - #6031
Conversation
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
|
Completed the decided quest plan at fe4dfd2. No open decisions or follow-up quests identified. Keep this draft under the user's no-merge hold; (written by GPT-6.1-Sol) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Nix development environment now selects the Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: selecting the wasm-bindgen CLI version from Cargo.lock in Nix. |
| Description check | |
The description directly explains the version-drift problem, the Cargo.lock-based solution, validation results, and the absence of public API or wire-format changes. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches
-
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed72c438ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (pkgs.lib.findSingle (package: package.name == "wasm-bindgen") | ||
| (throw "Cargo.lock has no wasm-bindgen package") | ||
| (throw "Cargo.lock has multiple wasm-bindgen versions") | ||
| (builtins.fromTOML (builtins.readFile ./Cargo.lock)).package |
There was a problem hiding this comment.
When the root Cargo.lock advances to another wasm-bindgen version, this switches the shell's global CLI while bench/ffi-gen/Cargo.lock remains independently pinned. bench/ffi-gen/run.sh builds its UniFFI WASM artifact with that second lockfile and then invokes the global wasm-bindgen, so the next root-only bump will make the benchmark fail with the same schema mismatch this change is intended to prevent. Either derive that build from the root lock too or add an explicit synchronization guard for the nested lockfile.
Useful? React with 👍 / 👎.
Problem
A nixpkgs update can change the default wasm-bindgen CLI independently of the locked crate, breaking their required schema match.
Approach
Read the locked wasm-bindgen version and select nixpkgs' versioned CLI. Refuse unsupported, missing, or ambiguous lock entries during Nix evaluation. Update the matching comments and complete the quest.
Decisions
Cargo.lock(maintainer, 2026-10-19). Rejected: a CI step comparing the two versions (detects drift instead of removing it), and making Dependabot's auto-merge wait for WASM.Impact
Validation
origin/main(conflict only inquest/m0/ci/README.md's Required list); scopedjust checkpasses again in the pinned Nix shell after the merge.Alternatives
A separate version-comparison CI step detects drift after it occurs. Selecting the matching CLI removes it, following the maintainer's decided quest plan.
Follow-ups
None identified.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)