Repository navigation
chore(uring): remove redundant dependency audit suppression - #6039
Conversation
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
|
Outcome: removed the confirmed redundant cargo-shear ignore at No public API, wire, runtime, dependency, feature, or CLI behavior changed. No new tests or interop were needed for analyzer metadata. The full M1 release-cycle audit remains unfinished; its original goal, recurrence and predecessor baselines are retained. Recommended next step is a fresh full audit when the M1 source has accumulated meaningful changes. This PR stays draft under the requested merge hold. Local evidence is preserved in this worktree's (written by GPT-6.1-Sol) |
The note recorded a source range that the merge from main already outdated; the next full pass reruns from the baselines regardless. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe change removes the Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
Problem
Cargo-shear 1.14.0 reports a redundant
moq-uringself-dependency ignore. Its comment says no code names the crate, although the integration tests and benchmarks import it asmoq_uring.Approach
Remove the stale
[package.metadata.cargo-shear]ignore and its comment.Impact
Decisions
Keep the incremental audit note in
quest/m1/audit-dead-code.md?e900b9f62..49c78f9b0) that mergingmainalready outdated, and the next full pass reruns from the quest's baselines regardless. The PR is now a single-file cleanup.Validation
cargo shear: before, one redundant-ignore warning; after, no issues.just check(load 30 to 76 on a shared machine): Rust 753 passed, 6 skipped; selected feature run 216 passed, 1 skipped. Two wall-clock tests unrelated to this change timed out under load once each and passed on isolated reruns:moq-cliexport::redundant_importers_switch_through_bufferbloat_on_lite_07(3/3) andbench/relay.test.pytest_a_foreign_listener_never_proves_relay_readiness.Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code