Skip to content

chore(uring): remove redundant dependency audit suppression - #6039

Merged
kixelated merged 4 commits into
mainfrom
quest/m1/audit-dead-code
Oct 20, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m1/audit-dead-code

Conversation

@kixelated

@kixelated kixelated commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Cargo-shear 1.14.0 reports a redundant moq-uring self-dependency ignore. Its comment says no code names the crate, although the integration tests and benchmarks import it as moq_uring.

Approach

Remove the stale [package.metadata.cargo-shear] ignore and its comment.

Impact

  • No public API, wire, runtime, dependency, feature, or CLI changes.

Decisions

Keep the incremental audit note in quest/m1/audit-dead-code.md?

  • Keep it
  • ✅ Drop it (recommended): it recorded a source range (e900b9f62..49c78f9b0) that merging main already outdated, and the next full pass reruns from the quest's baselines regardless. The PR is now a single-file cleanup.

Validation

  • cargo shear: before, one redundant-ignore warning; after, no issues.
  • just check (load 30 to 76 on a shared machine): Rust 753 passed, 6 skipped; selected feature run 216 passed, 1 skipped. Two wall-clock tests unrelated to this change timed out under load once each and passed on isolated reruns: moq-cli export::redundant_importers_switch_through_bufferbloat_on_lite_07 (3/3) and bench/relay.test.py test_a_foreign_listener_never_proves_relay_readiness.

Follow-ups

  • The M1 release-cycle dead code audit remains unfinished; this PR does not complete it.
  • The two load-sensitive tests above could be made deterministic.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 19, 2026 19:37
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome: removed the confirmed redundant cargo-shear ignore at 0a7aafa88a3b998a758ae8edc3703e22f70fe2bd. Before, cargo-shear reported one redundant-ignore warning; after, it reported no issues. Scoped just check exited 0: 746 native cases passed with 6 skipped, and 217 selected playback-feature cases passed with 1 skipped, plus the remaining selected checks. The source tree is clean.

No public API, wire, runtime, dependency, feature, or CLI behavior changed. No new tests or interop were needed for analyzer metadata. The full M1 release-cycle audit remains unfinished; its original goal, recurrence and predecessor baselines are retained. Recommended next step is a fresh full audit when the M1 source has accumulated meaningful changes. This PR stays draft under the requested merge hold.

Local evidence is preserved in this worktree's .scratch/evidence.json, analyzer logs, source delta, and full scoped-gate log.

(written by GPT-6.1-Sol)

kixelated and others added 2 commits October 19, 2026 21:43
The note recorded a source range that the merge from main already
outdated; the next full pass reruns from the baselines regardless.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 20, 2026 05:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T05:05:41.097890Z 51d6c86 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bb13f07e-169f-4ffe-a8c9-55ff41683a7c
📥 Commits

Reviewing files that changed from the base of the PR and between 9b90cdd and 51d6c86.

📒 Files selected for processing: 1
  • rs/moq-uring/Cargo.toml
💤 Files with no reviewable changes: 1
  • rs/moq-uring/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The change removes the package.metadata.cargo-shear configuration and its moq-uring ignore entry from the package manifest.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 51d6c

No actionable merge risk is evident from the metadata removal; normal checks can determine readiness.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the removal of redundant dependency audit suppression, which is the main change.
Description check Passed The description directly explains the removed Cargo-shear ignore, the reason for the change, its impact, and validation results.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 34a01e7 Oct 20, 2026
6 checks passed
@kixelated
kixelated deleted the quest/m1/audit-dead-code branch October 20, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant