Repository navigation
quest: plan resume through an undetected outage - #6065
Conversation
Adds quest/m1/resume-outage.md for a regression test and doc fix, and counts an unclosed route loss as the stall route health must first reproduce. Narrows the broadcast-epoch Goal: a same-epoch resume is still bounded by the subscriber's max age. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60cedfedde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Summary before merge:
The decisions are listed in the PR description. Codex's one finding (cover the exporter consumer) was addressed in 64e48f1. (Written by Claude Opus 5.5) |
…007b7 # Conflicts: # quest/m1/README.md
Imports issue #6062 (the only open issue without the
questlabel) as a quest. This PR mentions the issue but doesn't close it; the quest's PR will.Triage
Read against
5284d969bf; nothing was run.Reader::syncsubscribes the new copy at the newest group it handed out (model/resume.rs), and a cold relay forwards that start upstream.--delay / 2forexport ts) to the backlog that builds while the QUIC idle timeout detects the dead relay. The draft requires this ("A floor is not a request"). At the default delay, the reported loss is intended.--delay 10sis unexplained. The code predicts about 2 s lost there, but the report saw the same loss as at the default. That needs a reproduction.doc/concept/moq-lite.mdand the broadcast-epoch Goal promise resume "from the first frame it lacks" without mentioning the max-age bound.Changes
quest/m1/resume-outage.md[S], ranked in m1's resume cluster after "Resumed in-flight groups". It adds a mock-timeroute_change.rsregression test with a cold alternate route and an undetected outage, fixes any bug the test exposes in moq-net, and corrects the concept doc.quest/m0/broadcast-epoch/README.md: the Goal now says a same-epoch resume is bounded by the subscriber's max age.quest/m2/route-health/{README,design,recovery}.md: a route that dies without a close counts as the stall that transport failure misses until the idle timeout fires. Recovery should move off it before the timeout.Decisions
What should the quest deliver?
Should faster dead-route detection get planned work?
Milestone?
Test scope?
How should route-health absorb the undetected loss?
m1 rank?
Broadcast-epoch wording?
Public API and wire impact: none. This PR only changes quests.
quest checkpasses.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code