Skip to content

quest: plan resume through an undetected outage - #6065

Merged
kixelated merged 3 commits into
mainfrom
claude/quest-import-e007b7
Oct 20, 2026
Merged

kixelated merged 3 commits into
mainfrom
claude/quest-import-e007b7

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Imports issue #6062 (the only open issue without the quest label) as a quest. This PR mentions the issue but doesn't close it; the quest's PR will.

Triage

Read against 5284d969bf; nothing was run.

Changes

  • New quest/m1/resume-outage.md [S], ranked in m1's resume cluster after "Resumed in-flight groups". It adds a mock-time route_change.rs regression test with a cold alternate route and an undetected outage, fixes any bug the test exposes in moq-net, and corrects the concept doc.
  • quest/m0/broadcast-epoch/README.md: the Goal now says a same-epoch resume is bounded by the subscriber's max age.
  • quest/m2/route-health/{README,design,recovery}.md: a route that dies without a close counts as the stall that transport failure misses until the idle timeout fires. Recovery should move off it before the timeout.

Decisions

What should the quest deliver?

  • ✅ Repro test + doc fix (recommended)
  • Doc fix only, close
  • Recover the whole gap regardless of max age
  • Won't fix

Should faster dead-route detection get planned work?

  • No, operator tuning (recommended)
  • ✅ Extend route-health
  • New quest: defaults

Milestone?

  • ✅ m1 standalone (recommended)
  • m0 broadcast-epoch child
  • m2

Test scope?

  • ✅ Model-level only (recommended)
  • Model + e2e relay
  • E2E only

How should route-health absorb the undetected loss?

  • ✅ Count it as the gate stall (recommended)
  • New route-health child
  • Note in recovery.md only

m1 rank?

  • ✅ In the resume cluster (recommended)
  • Ahead of the resume cluster
  • End of m1 feature list

Broadcast-epoch wording?

  • ✅ Fix it in this PR (recommended)
  • Leave it to the quest

Public API and wire impact: none. This PR only changes quests.

quest check passes.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Adds quest/m1/resume-outage.md for a regression test and doc fix, and
counts an unclosed route loss as the stall route health must first
reproduce. Narrows the broadcast-epoch Goal: a same-epoch resume is
still bounded by the subscriber's max age.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 402a9b82-f35e-4ef3-a633-fa0d18a06d10
📥 Commits

Reviewing files that changed from the base of the PR and between 29cf6ca and f4cbd6f.

📒 Files selected for processing: 6
  • quest/m0/broadcast-epoch/README.md
  • quest/m1/README.md
  • quest/m1/resume-outage.md
  • quest/m2/route-health/README.md
  • quest/m2/route-health/design.md
  • quest/m2/route-health/recovery.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T16:50:06.571601Z f4cbd6f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60cedfedde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/resume-outage.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Summary before merge:

  • Plans quest/m1/resume-outage.md for Same-epoch resume after a relay loss continues at a later group, not the first frame lacked #6062. Resume already asks for the first missing group; the subscriber's max age sheds the backlog that builds while the idle timeout detects the dead relay. The quest adds a mock-time regression test in moq-net, plus a moq-mux consumer test if moq-net passes, so the unexplained --delay 10s loss gets explained or fixed at its source. It also corrects the concept doc.
  • The broadcast-epoch Goal now says a same-epoch resume is bounded by the subscriber's max age.
  • Route health counts a route that dies without a close as the stall it must first reproduce, and should fail over before the idle timeout fires.

The decisions are listed in the PR description. Codex's one finding (cover the exporter consumer) was addressed in 64e48f1.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 20, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit eca6e73 Oct 20, 2026
4 checks passed
@kixelated
kixelated deleted the claude/quest-import-e007b7 branch October 20, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant