Skip to content

build(nix): pin Quest with the local command gate - #6215

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/ci/quest-gate-pin
Oct 22, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/ci/quest-gate-pin

Conversation

@kixelated

@kixelated kixelated commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The pinned Quest CLI has no quest gate, blocking the separate quest to admit expensive local checks across repositories and worktrees. The implementation has landed upstream in kixelated/quest#128; kixelated/quest#177 subsequently completed its contention measurements. kixelated/quest#180 plans later headroom improvements and does not block this pin.

Approach

Advance only the Quest input from a5b83a3dfd14492d62011afdb3c3893fcebbcca6 to the gate implementation's merged revision, a73fb295a3679ff54205af68a1a7bb8ec5bdc7af, and regenerate its lock entry. Complete the pin quest and remove its two references, unblocking entrypoint adoption.

Impact

  • The Nix devshell and packages.quest now provide quest gate, along with that revision's bundled Quest guide and skills.
  • Consumer: developer tooling for the existing local-gate adoption quest. This PR makes the primitive available; it does not gate moq's entrypoints yet.
  • No MoQ public API, wire-format or runtime behavior changes.

Validation

  • The pinned Nix package builds, and quest gate --help describes host load/memory admission and immediate nested calls.
  • A real command preserves literal arguments, working directory, the admission marker and exit status 37; nested gates preserve exit status 23.
  • quest check --base origin/main: 445 documents pass.
  • nix flake check --no-build and git diff --check pass.
  • The full just ci gate was not run locally: its runner-image build needs user namespaces the agent host lacks (systemd-repart cannot write /proc/self/uid_map). The merge queue's Check job runs the full gate.

Alternatives

Pinning the gate's merge revision keeps later upstream work outside this update. Waiting for the headroom follow-up would unnecessarily delay the available primitive.

Follow-ups

Entrypoint adoption, worker fanout and contention measurement remain in quest/m0/ci/local-gate.md.

Decisions needed

None.

(Written by GPT-6 and Claude Opus 5.5)

kixelated and others added 2 commits October 21, 2026 15:30
Co-Authored-By: GPT-6 <noreply@openai.com>
Advance the Quest input to the merged gate implementation, verify command help and exact/nested exit statuses, and complete the pin quest. Repository entrypoint adoption remains separate.

Co-Authored-By: GPT-6 <noreply@openai.com>

Copy link
Copy Markdown
Collaborator Author

Quest outcome: upstream availability is verified by merged kixelated/quest#128 and the Nix-built binary at its merge revision. The input is pinned, the completed pin quest is removed, and local-gate entrypoint adoption is unblocked.

The pinned command's help, exact argv/cwd/exit-status and nested-command smoke tests pass. Quest validation (445 documents), flake evaluation and whitespace checks pass. Full just ci remains blocked by the host's prohibited user namespace while building the runner image; no unrelated policy changes were made. No design decision remains and no additional quest is proposed. Suggested next action is /quest-ready once the complete gate can run on a suitable host. Nothing was merged or enqueued.

(Written by GPT-6)

@kixelated
kixelated marked this pull request as ready for review October 21, 2026 23:33
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 894f38f7-29a7-40d7-8bc8-d1439cb8279f
📥 Commits

Reviewing files that changed from the base of the PR and between bd1d7ad and 509776b.

⛔ Files ignored due to path filters: 1
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
  • flake.nix
  • quest/m0/ci/README.md
  • quest/m0/ci/local-gate.md
  • quest/m0/ci/quest-gate-pin.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T04:21:04.806481Z 509776b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: pins the Quest flake input to a73fb295 (merged kixelated/quest#128) so the devshell provides quest gate, deletes the completed pin quest, and unblocks quest/m0/ci/local-gate.md. No MoQ API, wire, or runtime changes.

Review: Codex reviewed head d3432ed with no findings (CodeRabbit was rate limited). PR checks pass; the full Check job runs in the merge queue. No open decisions. Enabling auto-merge on that head.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
@kixelated
kixelated enabled auto-merge October 22, 2026 04:19
@kixelated

Copy link
Copy Markdown
Collaborator Author

Re-queued after merging main (509776b). The only conflict was in quest/m0/ci/README.md's Required list: main removed the finished audit entry and this PR removes the pin entry, so the merge drops both. flake.lock merged cleanly and still pins quest at a73fb295.

Checks: quest check (460 documents), nix flake check --no-build, and the markdown, shell, toml, nixfmt, justfile, gh and OBS modules pass, and .#quest builds. Building the runner image in the flake module fails locally on the known user-namespace limit, so the queue covers it. Codex's no-findings review of d3432ed still applies, since the change since then is a quest-only conflict fix.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit e0cde15 Oct 22, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/ci/quest-gate-pin branch October 22, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant