Repository navigation
chore(quest): retire merged binding linger work - #6229
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Verified the actual merged binding implementation from moq-dev/moq#6157 at main commit 150111b. This change retires only its stale quest and four references. All 19 targeted FFI/C finish tests, The merged maintainer decisions remain unchanged. No new scope or API decision was needed. JSON/flate retention remains an optional separate quest-planning follow-up; interop finish remains blocked on JS linger. (Written by GPT-6) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Drop the JS and binding linger requirements from interop-finish, since both landed, and remove binding linger from the generated C epic's list: #6157 shipped the C half, and the generated package inherits the moq-ffi finish handle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged
(Written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged (Written by Claude Opus 5.5) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffe83fb467
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -19,7 +19,3 @@ while their examples only use `Moq.connect`, which never hands back a | |||
| binding PRs that also touch those pages have landed. | |||
There was a problem hiding this comment.
Removing the final ## Required section makes this quest ready immediately, even though its plan still says these documentation edits must wait for both the linger and auth binding PRs. quest/m1/auth/bindings-polish.md only lists this quest as Related, so it creates no dependency, and that m1 auth work remains open; a quest runner can now start this work concurrently and conflict on the same Kotlin and Dart pages. Replace the retired linger edge with an explicit dependency on Binding auth polish.
Useful? React with 👍 / 👎.
Problem
The ready quest tree still assigns binding linger work already merged in moq-dev/moq#6157, and leaves completed prerequisites on the interop finish and Go first-dial quests.
Approach
Verified main contains merge commit 150111bc3f. The merged code consumes the broadcast into a finish handle, retains finished raw/media tracks until broadcast end, exposes linger/wait/interrupt across the bindings, and includes wrapper smoke tests and documentation. The Python test-clock regression checks late tail delivery before 2 seconds and expiry at 2 seconds; FFI/C tests cover retention and interruption.
Delete the completed quest and its references. Merging main brought a requirement from moq-dev/moq#6092 that the C half land on the generated C package; #6157 already shipped it on hand-written moq-c, and the generated package inherits the moq-ffi finish handle, so the quest is dropped from that epic's list too. JS linger also landed, so interop-finish is now unblocked. Existing consumers are quest runners selecting ready work and the dependent interop/Go quest plans.
Impact
Checks
just ci: passed.54fcb06b4c90a24bc43d06efa104c54d4481166a.quest check: 462 documents valid after merging main; no remaining path references.just rs test -p moq-ffi -p moq-c -E 'test(finish) | test(cancelling_the_wait)': 19 passed.Alternatives
Reimplementing the merged L-sized quest would duplicate working code. Keeping the stale quest would continue recommending completed work.
Follow-ups
No open decisions for this retirement. The interop finish quest is now ready. Optional separate
/quest-plan: retain finished JSON/flate producers in moq-mux, as approved for later consideration in decision 5 of the merged PR. No separate quest currently records it, and this PR does not create or implement it.(Written by GPT-6)