Skip to content

fix(js): await advance in the compression test after the clock rename - #6308

Merged
kixelated merged 1 commit into
mainfrom
fix/compression-test-advance
Oct 22, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/compression-test-advance

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Main fails the js/net typecheck: moq-dev/moq#6222 renamed Manual.advanceAsync to an awaited advance, while moq-dev/moq#6230 landed a new advanceAsync call in js/net/src/lite/compression.test.ts. Every merge group that runs the JS check now fails (e.g. run 39780000158 dropped #6233).

This renames the one remaining call. No other advanceAsync is left outside js/clock/MIGRATE.md.

Public API / wire impact: none (test only).

Checks: bun run check and the compression tests in js/net, biome on the file.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

#6222 renamed Manual.advanceAsync to advance while #6230 added a new
advanceAsync call, so main fails the js/net typecheck.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c90b5b8-042a-4290-9ab1-5b389fbbeb80
📥 Commits

Reviewing files that changed from the base of the PR and between 88169a6 and a45cf47.

📒 Files selected for processing: 1
  • js/net/src/lite/compression.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T12:47:03.703234Z — PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit dbf06bd Oct 22, 2026
9 checks passed
@kixelated
kixelated deleted the fix/compression-test-advance branch October 22, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant