Repository navigation
quest: plan the release audit's unowned follow-ups - #6342
Conversation
Seven verified remainders from merged PRs get quests: qmux local abort and close, a JS release dependency preflight, the HLS segment cursor failure, draft 14-16 session errors, moqsrc surround Opus, and low-rate AC-3. The four unpublished @moq npm names get a human-action quest gating the cut, and the recurring quest audit now reconciles merged PR follow-ups. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bfac1ac00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging. Plans eight quests from the release audit's follow-ups and adds a follow-up reconciliation step to the recurring quest audit. Every decision is recorded in the PR body. Review: Codex reviewed 6bfac1a with two findings. The qmux close bound is fixed in 1c80836: close delivers APPLICATION_CLOSE if the socket drains before the stall deadline and closes without it otherwise. Making the HLS cursor private is declined per maintainer decision 8. (Written by Claude Opus 5.5) |
# Conflicts: # quest/m1/README.md
|
Merged main after #6351 landed: both PRs added entries at the same spot in (Written by Claude Opus 5.5) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b4540a3c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [API-diff check](/quest/m2/release/migrate-audit.md) - PRs into release diff the public API; backports refuse breaks, the cut confirms MIGRATE.md coverage | ||
| - [API shape review](/quest/m2/release/api-review.md) - every new or changed public API reviewed for a better shape before the cut | ||
| - [Feature review](/quest/m2/release/feature-review.md) - every major work line since the last release judged end to end before the cut | ||
| - [Claim new npm names](/quest/m2/release/npm-first-publish.md) - a maintainer claims `@moq/clock`, `libav`, `video`, and `p2p` on npm and JSR with trusted publishing, before the cut publishes them |
There was a problem hiding this comment.
This prerequisite is scheduled under release execution, which starts only after m1, but the m1 preflight is intended to fail dry runs while an @moq/* range is unpublished. Because the nightly workflow already invokes release-js.yml on main and these four names remain absent until this quest runs, landing the preflight first would make that nightly fail throughout the rest of m1. Move the name-claiming action ahead of the preflight, or make it an explicit m1 prerequisite, so the required nightly remains viable.
AGENTS.md reference: AGENTS.md:L28-L28
Useful? React with 👍 / 👎.
Summary
A release audit of
mainagainstreleasefound concrete follow-ups that merged PRs named but nobody owned. Each one was checked against current source and open PRs before planning. Seven remain, and planning turned up an eighth item the audit missed.m1 (before the cut)
[S]: injs/qmux,writer.abort()waits for the peer to grant credit, andclose()sleeps 100 ms and then closes a backed-up socket without ever writing APPLICATION_CLOSE. Both were deferred in quest(m1): build @moq/qmux from js/qmux #6124. Rustrs/qmuxis fine.[S]:release.tsrefuses to publish a package whose@moq/*dependency is not on npm (feat(hang): decode AAC in the libav fallback via a Nix-built @moq/libav #6243's follow-up).[S]:segments::Consumer::nextreturnsOk(None)when the timeline fails (fix(hls)!: a failed export timeline answers its listings with an error #6153's follow-up). The fix is breaking.m2
[XS], a human action that gatescut.md. New finding:@moq/clock,@moq/libav,@moq/video, and@moq/p2pall 404 on npm, and nearly every package now depends on@moq/clock. Trusted publishing needs the name to exist first, so the cut's JS publish would fail and still push dependents that can't install.clock,video, andp2pare also missing on JSR.[S]:ControlStreamAdapterflattens session errors toClosed, so a terminal rejection can be redialed (fix(net): refetch a resumed group only when its route failed delivering it #6251's follow-up).[S]: moqsrc caps omit the Opus mapping fields, soopusdecrefuses 3 to 8 channels (fix(moq-gst): publish the OpusHead for surround caps #4991's follow-up).m3
[XS]: supports bsid 9/10 and removes theac3_coreinconsistency (fix(ts): split and buffer-model DVB E-AC-3 access units #5758).Dropped as already owned:
quest/m0/release-backports/tls.md.Decisions
ac3_coreconsistent onlym2/release, gatingcut.md0.0.0placeholder per name; the cut publishes the real0.1.0with provenance0.1.0Public API and wire
None in this PR. The planned HLS fix is a breaking change to
moq-hlsand will carry its ownMIGRATE.mdentry.Checks
quest check: 454 documents ok.just fix: clean.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)