Repository navigation
quest: qmux receive leases and the pre-draft-20 join after a quick finish - #6352
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b82cff679c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Recommendation: the subscription limit, plus the request close where the | ||
| draft has one. Keep only entries that can be answered (`Joined::Group`); an | ||
| unsubscribed or refused subscription still drops its entry at once. A head | ||
| evicted from the cache meanwhile stays a loud refusal. The existing wait in |
There was a problem hiding this comment.
When a SUBSCRIBE is admitted by a request-borne token, retaining its Joined::Group after the subscription completes also outlives the RequestGrant that enforces expiry and revocation. This is especially unbounded on drafts 14–16, where there is no per-request close signal: the later joining FETCH uses the retained entry and a Gate::named() session-grant check, so it can read cached data after the authorizing request token has expired or been revoked. Include request-grant lifetime among the removal conditions and add a mocked-time expiry/revocation test.
AGENTS.md reference: AGENTS.md:L17-L18
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in d37b7bf: the plan now drops a retained entry when the subscription's request-token grant expires or is revoked, or the session grant stops covering the track, and the test plan adds a mocked-time expiry and a revocation case.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review (Written by Claude Opus 5.5) |
…letes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Records two maintainer-approved follow-up quests in m2.
quest/m2/qmux-receive-lease.md: after moq-dev/moq#5878, qmux still reads through moq-net'spoll::Bufferedand returns credit as it reads, so incomplete messages are not bounded in aggregate and nothing is evicted. Native leasing needs a window of at leastMIN_RECEIVE_WINDOW(64 MiB + 16) against qmux's 1 MiB default. The quest weighs that per-session cost against a version-aware smaller floor and a grow-on-demand window, and asks the maintainer to pick before building. It lists Bound message assembly as a Required blocker. feat(quic)!: bound incomplete messages with receive leases #5878 deletes that quest, so it has to drop this link too when it lands.quest/m2/ietf-join-after-finish.md: after moq-dev/moq#6348, a refused joining FETCH fails the subscription. Our IETF publisher drops a subscription's join entry when it ends, so a track that finishes within about one RTT of SUBSCRIBE_OK fails instead of finishing cleanly. The quest keeps the finished entry, bounded by the subscription limit and, on drafts 17 to 19, by the request's close, never by a timer. It includes a mocked-time test plan. fix(net): join pre-draft-20 subscriptions at the live group #6348 has no quest, so its plan states the dependency instead. It is ranked low in m2 because pre-draft-20 drafts are low priority.quest checkandquest check --base origin/mainpass.Public API: none. Wire: none.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code