Skip to content

quest: plan follow-ups from the 2026-10-22 quest spawn - #6354

Merged
kixelated merged 8 commits into
mainfrom
quest/plan-spawn-followups
Oct 22, 2026
Merged

kixelated merged 8 commits into
mainfrom
quest/plan-spawn-followups

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Plans the follow-ups found while working this session's quest PRs. Quest files only.

New quests

m1:

m2:

Decisions

Which follow-ups to plan (multi-select):

  • Bugs: ✅ FFI shutdown drain, ✅ JS same-process NAMESPACE_DONE, ✅ JS gets no objects from imquic, moq-rtc rendition move (not planned)
  • Tests: ✅ Nightly just obs test, ✅ resource-instrumentation flake, ✅ cpp->js 30s overrun, browser playout glitches (not planned)
  • Upkeep: ✅ readers use Range::live(), ✅ polyfill fix in fork, ✅ runner client bump, moqsrc EOS (not planned)

FFI shutdown: how should Session::shutdown guarantee the drain starts?

  • Never abort the close (no API change)
  • ✅ Sync begin + async wait
  • Document it

FFI shutdown API shape:

  • ✅ Sync shutdown() + existing closed()
  • Sync drain() + closed()
  • Keep async shutdown() + add begin_shutdown()

Polyfill fix:

  • Fork + upstream report
  • ✅ Fork only

Also decided in the same interview and applied in their own PRs: #6278's track-live quest drops its Required on public-model/serve.md (#6138 merged); #6280's listing-end-reason uses a new TracksEvent::Finished variant and Lister::finish, a new lite-07 TRACKS_FINISH event, and lands in m1 Required by lite07-finalize.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c684ad29-c423-42c5-bbfa-2f5505ba658e
📥 Commits

Reviewing files that changed from the base of the PR and between e5842cc and cd06786.

📒 Files selected for processing: 12
  • quest/m1/README.md
  • quest/m1/ffi-shutdown-sync.md
  • quest/m1/interop-coverage/README.md
  • quest/m1/libav-polyfill-fork.md
  • quest/m1/obs-test-nightly.md
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/interop-cpp-js.md
  • quest/m1/test-flakes-2/resource-instrumentation.md
  • quest/m2/README.md
  • quest/m2/readers-range-live.md
  • quest/m2/release/README.md
  • quest/m2/release/runner-client-bump.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T20:45:48.772897Z cd06786 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e413cf3552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/interop-coverage/README.md Outdated
Comment thread quest/m2/readers-range-live.md Outdated
Comment thread quest/m2/readers-range-live.md Outdated
kixelated and others added 2 commits October 22, 2026 11:27
@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 86958950f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary for 8695895:

  • Moved the runner client bump from the m1 interop-coverage epic to release execution: feat(net)!: an undeclared Rust timescale means untimed #5083 publishes only with the next cut, so requiring it under m1 deadlocked the cut. The epic lists it as Related.
  • Latest readers now take a relative range, keeping moq-video's one-group warmup lookback, inventory js/ and poll_largest too, and require JS ranges for @moq/room chat.
  • Merged origin/main; quest check passes on the head and on a trial merge with the latest main. Codex reviewed 8695895 with no findings.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
kixelated and others added 2 commits October 22, 2026 13:20
# Conflicts:
#	quest/m1/README.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main: #6284 finished interop-audio, so the m1 README keeps main's three new audio quests, drops interop-audio, and libav-polyfill-fork loses its link to it. Quest check passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 22, 2026 20:20
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
kixelated and others added 2 commits October 22, 2026 13:38
Drop js-namespace-withdraw and js-imquic-objects, which #6275 owns.
Move the two load flakes into test-flakes-2 as its children, and link
ffi-shutdown-sync to the MIGRATE quest that must describe its final shape.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
@kixelated
kixelated enabled auto-merge October 22, 2026 20:43
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main: #6275 landed interop-coverage/js-namespace-done.md, the same NAMESPACE_DONE investigation as this PR's js-namespace-withdraw.md, so I dropped this PR's duplicate and kept main's (it also covers the relay-side classification). The m1 README keeps both new entries. Quest check passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
@kixelated
kixelated removed this pull request from the merge queue due to a manual request Oct 22, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 50f52ea Oct 22, 2026
11 checks passed
@kixelated
kixelated deleted the quest/plan-spawn-followups branch October 22, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant