Skip to content

quest: delete media resource instrumentation - #6439

Merged
kixelated merged 4 commits into
mainfrom
quest/m1/test-flakes-2/resource-instrumentation
Oct 26, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m1/test-flakes-2/resource-instrumentation

Conversation

@kixelated

@kixelated kixelated commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes the abandoned Media resource instrumentation quest with quest rm, which also drops its entry from the test-flakes-2 epic.

Why

The original failure (the media test's player reporting nothing to release while still playing) has not reproduced. Five resource ownership checks passed in the 2026-10-22 investigation, including runs pinned to two CPUs, and this PR had become a diagnostic checkpoint with no causal fix. The maintainer decided to abandon the quest rather than keep a draft waiting on a failure that may not recur. If it does recur, the media-window diagnostics from moq-dev/moq#6302 already print each page's long animation frames and the host's busiest processes, and a new quest can start from that trace.

Dropped

The PR previously added extra logging in test/interop/clients/js/media.ts (the sampled resource counts before detach, and the full player state on failure) and a new media-tone-windows quest for the audio-tone agreement recurrence seen during validation. Both are dropped so this PR only deletes a quest. The tone-window evidence stays in this PR's history (commit 058a24ce76) if that quest is planned separately.

Public API and wire impact

None. Quest files only.

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title The media test's resource instrumentation reports what the player holds test(media): diagnose resource ownership before detach Oct 23, 2026
kixelated and others added 2 commits October 26, 2026 10:21
…2/resource-instrumentation

# Conflicts:
#	quest/m1/test-flakes-2/README.md
The original failure has not reproduced, and the only work left on it was
a diagnostic checkpoint with no causal fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title test(media): diagnose resource ownership before detach quest: delete media resource instrumentation Oct 26, 2026
@kixelated
kixelated marked this pull request as ready for review October 26, 2026 17:22
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bfe4e836-5200-4b45-a6cd-951400b0d16b
Commits

Reviewing files that changed from the base of the PR and between 849aab9 and eee58dd.

Files selected for processing: 2
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/resource-instrumentation.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T17:23:48.127128Z eee58dd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head eee58dd41cceee12bb2108ddd0567821e533ce76 against base 849aab9e8151f3f4e66b67485a51ae9c51d94221.

No actionable findings. The net change deletes only the abandoned quest and its parent’s Required entry; the earlier media-test logging and tone-window quest are absent from the final diff. Given the stated decision to abandon the investigation, this is the minimal consistent cleanup—not a fix or proof that the original flake is resolved.

Verification: inspected the complete two-file diff, surrounding epic, commit history, and existing reviews. Static GitHub-only review; no tests run or independent reproduction of the reported investigation.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing: the PR now only deletes the media resource instrumentation quest via quest rm (main merged in, the media.ts logging and the media-tone-windows quest dropped). Codex reacted with no findings and the automated review found nothing actionable; checks pass. moq-dev/moq#6854 left the queue on a separate merge conflict; when it is updated, its m1 test-flakes-2 stub (which only waits on this PR's claim) should be dropped instead of kept.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 1162f0b Oct 26, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m1/test-flakes-2/resource-instrumentation branch October 26, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant