Skip to content

ci(obs): run the OBS ThreadSanitizer suite nightly - #6469

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/obs-test-nightly
Oct 23, 2026
Merged

ci(obs): run the OBS ThreadSanitizer suite nightly#6469
kixelated merged 2 commits into
mainfrom
quest/m1/obs-test-nightly

Conversation

@kixelated

@kixelated kixelated commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Finishes quest/m1/obs-test-nightly.md.

Summary

Nothing ran just obs test (the OBS plugin's ThreadSanitizer suite), so it failed on main unnoticed until moq-dev/moq#6277 fixed its suppression rule. This adds an OBS TSan lane to the Nightly recipe matrix, so a failure shows up as Nightly (OBS TSan) like any other lane.

  • The lane uses the plain dev shell, not .#obs as the quest planned: the suite links stubbed libobs, and the default shell already carries obsDeps (pinned libobs headers, simde, ffmpeg). .#obs only adds the linked obs-studio, which just obs ci needs and this does not. Verified by running it in the default shell.
  • It is its own lane rather than folded into OBS, so it runs in parallel and a TSan failure is not confused with a link failure.
  • Comments that called the suite manual (cpp/obs/justfile, sh/obs/test.sh, sh/obs/compile.sh) now say it runs nightly.
  • Deletes the quest and its m1 link.

Consumer: the Nightly workflow.

Runtime

Measured locally on x86_64 (24 cores, GCC 16.2 from the dev shell): 262 s cold including the moq-ffi cargo build, 132 s warm. The runner is the default 4-core ARM one, so expect a few minutes; a loaded run of moq-output-test alone can take 60 to 90 s instead of about 8. Well inside the lane's 60 min timeout. Not run on ARM: test.sh's probe refuses loudly if the runner's TSan runtime does not work there.

Public API and wire

None.

Checks

  • just obs test: passed (twice, default shell).
  • just check: passed.
  • Nightly not dispatched by hand; the first scheduled run after merge exercises the lane.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 22, 2026 20:56
@kixelated
chore(quest): claim quest/m1/obs-test-nightly.md
473d1a6 
Quest-Claim: a3dd68e709c2511e
@kixelated @claude
ci(obs): run the OBS ThreadSanitizer suite nightly
cd28bff 
Nothing ran `just obs test`, so it failed on main unnoticed until #6277.
A Nightly lane now runs it in the plain dev shell: the tests stub libobs,
so the `.#obs` shell's obs-studio is not needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Nightly runs the OBS TSan suite ci(obs): run the OBS ThreadSanitizer suite nightly Oct 23, 2026
@kixelated
kixelated marked this pull request as ready for review October 23, 2026 04:05
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 759656e9-8f5c-4a7a-a507-2e30cca3f74e
📥 Commits

Reviewing files that changed from the base of the PR and between 648df59 and cd28bff.

📒 Files selected for processing: 6
  • .github/workflows/nightly.yml
  • cpp/obs/justfile
  • quest/m1/README.md
  • quest/m1/obs-test-nightly.md
  • sh/obs/compile.sh
  • sh/obs/test.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T04:07:54.680459Z cd28bff Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

kixelated commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

Outcome: the quest is complete and has no open decisions. Nightly gains an OBS TSan lane that runs just obs test in the plain dev shell, because the suite stubs libobs and doesn't need .#obs. The comments that called the suite manual are updated, and the quest file is deleted.

Locally, just obs test passed in 262 s cold and 132 s warm (x86_64, 24 cores), and just check passed. It hasn't run on the ARM runner yet. The first scheduled Nightly after merge will exercise it.

Codex reacted with a thumbs-up. CodeRabbit was rate-limited and did not review. All required checks pass.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit fc6f2dd Oct 23, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/obs-test-nightly branch October 23, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kixelated