Tooling tests gate every merge by kixelated · Pull Request #6480 · moq-dev/moq

kixelated · 2026-10-23T03:56:19Z

Problem

just gh test covers the CI selector, release, size, and benchmark tooling, but only Nightly ran it. A PR that broke a fixture or added an unregistered bench merged green and reddened the next night, which happened three times in two days during the m1 run.

Change

sh/dispatch.sh: the gh module (empty pattern, so selected on every diff) now runs just gh test in the check test phase, timed as test gh in the per-module summary. Every just check and every queue/PR Check runs it. It runs unconditionally rather than by path, since path selection would let a broken selector skip the tests that catch it.
The gh module's tool list gains every executable the suite needs (python3, cargo, clippy-driver, dpkg-deb, nfpm, rpm), so under MOQ_STRICT a missing tool fails up front instead of mid-suite, and a local run without them skips the module.
sh/gh/nightly.sh runs moq-relay's http_auth bench, which moq-dev/moq#6488 added without registering; the newly gated suite caught it after merging main.
Nightly drops its separate gh test matrix entry: its gate entry runs just ci --all, which now includes it.
Comments and docs that said no pull request runs it are updated (.github/justfile, .github/ffi.md, sh/js/README.md, quest/m2/audit-ci.md).

The suite took about 25 s on an idle machine (270 s under heavy load). The fixture break the quest found on main was fixed by moq-dev/moq#6325; just gh test passes on current main.

Public API and wire impact

None. CI tooling only.

Consumer

The merge queue's Check job (.github/workflows/check.yml) and local just check.

Checks

just gh test: pass, plain and with the queue's MOQ_STRICT=1 NEXTEST_PROFILE=ci NEXTEST_TEST_THREADS=24 environment.
just gh check (actionlint over the edited Nightly matrix, alert coverage): pass.
sh/dispatch.sh check HEAD (the always-selected modules plus the new test gh phase): pass; the timing table lists test gh.
quest check: pass.
Full just check not completed locally: editing sh/dispatch.sh selects every module, and on a shared, heavily loaded machine it was still in cpp check after 100 minutes. The ready-for-review Check runs that full gate.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Quest-Claim: 0f4625602d62664e

`just gh test` covers the CI selector, release, size, and benchmark tooling, but only Nightly ran it, so a change that broke a fixture merged green. The gh module runs on every diff, so its test phase now runs the suite in every `just check` and queue Check. Nightly's `gate` covers it, so its separate matrix entry goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated · 2026-10-23T05:45:08Z

Outcome: the quest is complete, with no open decisions. Every just check and queue Check now runs just gh test as the gh module's test gh phase, and Nightly's separate gh test entry is gone because gate already covers it. Local runs of just gh test, just gh check, quest check, and the always-selected dispatch path passed. The full just check was stopped on a heavily loaded shared machine; this ready-for-review Check runs the full gate.

Follow-up worth watching: the suite took 25 s idle but 270 s under load locally. When idle, two Rust scratch builds account for most of it: sh/rs/test-lints.test.py (9 s) and sh/rs/select.test.py (7 s). If the queue's test gh row grows past a few percent of an entry, make those cheaper at their source.

(Written by Claude Opus 5.5)

coderabbitai · 2026-10-23T05:45:09Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 32ebb008-a7dd-49e0-b00c-06b17011b610

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8bd3f and 83cd833.

📒 Files selected for processing: 9

.github/ffi.md
.github/justfile
.github/workflows/nightly.yml
quest/m1/README.md
quest/m1/gh-test-gate.md
quest/m2/audit-ci.md
sh/dispatch.sh
sh/gh/nightly.sh
sh/js/README.md

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-23T05:45:16Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T18:40:56.040502Z	`83cd833`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 334467f7df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# Conflicts: # quest/m1/README.md

The always-selected gh module now runs `just gh test`, whose package and lint tests need rpm, nfpm, dpkg-deb and clippy-driver. List them so a local run skips the module and MOQ_STRICT reports them up front instead of failing mid-suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

#6488 added the bench target without registering it, which the newly gated `just gh test` catches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated · 2026-10-23T16:19:16Z

Merge summary:

Merged main; the conflict in quest/m1/README.md dropped both this quest's line and nix-cluster-connect, which main already finished.
Codex finding (tool preflight): fixed in 2993739, the gh module now lists clippy-driver dpkg-deb nfpm rpm too.
After the merge, just gh test failed on the unregistered moq-relay http_auth bench from moq-dev/moq#6488, exactly what this gate exists to catch; a95a15c registers it in the Nightly rust-bench shared invocation.
Local: quest check, shellcheck/shfmt, just gh check, and just gh test pass. The full just check runs in the queue's Check.
Codex gave the final head a thumbs-up.

(Written by Claude Opus 5.5)

kixelated · 2026-10-23T17:56:56Z

Dropped from the merge queue: the queue Check's newly gated test gh phase failed in sh/rs/select.test.py, which inherits GITHUB_ACTIONS=true and so sees the hosted --timings flag. The same failure reddens Nightly on main, and moq-dev/moq#6555 fixes it (queued now). Once that lands, merge main here and re-queue.

(Written by Claude Opus 5.5)

# Conflicts: # quest/m1/README.md

kixelated and others added 2 commits October 22, 2026 20:56

chore(quest): claim quest/m1/gh-test-gate.md

57e934d

Quest-Claim: 0f4625602d62664e

kixelated marked this pull request as ready for review October 23, 2026 05:45

chatgpt-codex-connector Bot reviewed Oct 23, 2026

View reviewed changes

Comment thread sh/dispatch.sh Resolved

kixelated and others added 3 commits October 23, 2026 09:05

Merge remote-tracking branch 'origin/main' into merge-6480

0cb1426

# Conflicts: # quest/m1/README.md

fix(ci): run the relay's http_auth bench nightly

a95a15c

#6488 added the bench target without registering it, which the newly gated `just gh test` catches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated added this pull request to the merge queue Oct 23, 2026

kixelated mentioned this pull request Oct 23, 2026

bench: pair nightly Criterion runs against the previous nightly #6511

Merged

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2026

Merge remote-tracking branch 'origin/main' into merge-6480

83cd833

# Conflicts: # quest/m1/README.md

kixelated added this pull request to the merge queue Oct 23, 2026

Merged via the queue into main with commit 119df3f Oct 23, 2026
10 checks passed

kixelated deleted the quest/m1/gh-test-gate branch October 23, 2026 20:54

kixelated mentioned this pull request Oct 24, 2026

docs(quest): plan merge queue latency improvements #6585

Merged

Navigation Menu

Repository navigation

Tooling tests gate every merge - #6480

Tooling tests gate every merge#6480
kixelated merged 6 commits into
mainfrom
quest/m1/gh-test-gate

kixelated commented Oct 23, 2026 •

edited

Loading

Uh oh!

kixelated commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

kixelated commented Oct 23, 2026

Uh oh!

Uh oh!

kixelated commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kixelated commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Public API and wire impact

Consumer

Checks

Uh oh!

kixelated commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kixelated commented Oct 23, 2026

Uh oh!

Uh oh!

kixelated commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kixelated commented Oct 23, 2026 •

edited

Loading

kixelated commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading