Repository navigation
quest: import open issues (64-bit hops, IETF AUTH_OK patterns, 0x16, H.265 aspect backport) - #6580
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 034e7e0ef7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ugh moq-auth Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Summary: imports #6545, #6566, #6567, and #6536 as four quests (m0: 64-bit Hop IDs, the 0x16 session code, the #5574 release backport; m1 auth epic: patterns in IETF AUTH_OK), with every decision recorded in the PR body. #6546 is left to #6554, which removes Review round 1 (Codex): the AUTH_OK quest now negotiates -01 under a new AUTH Setup Option code point so a -00 peer doesn't misparse it, and the 0x16 quest carries "malformed" through moq-auth's refusal contract to moq-relay (resized to [S]). Codex approved the new head. (Written by Claude Opus 5.5) |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Imports the open issues without the
questlabel. Issues are mentioned without closing keywords; each quest's PR closes its own.Quests
quest/m0/hop-id-64.md[M]: Hop IDs becomeu64end to end (moq-net, js/net, cluster and lite drafts); lite-01..06 links send an unencodable hop as 0. Tracks moq-net refuses a HOP_ID at or above 2^62, which moq-cluster-01 allows; moqx main now sends one three times in four #6545.quest/m0/malformed-auth-token-code.md[XS]:SessionError::MalformedAuthToken= 0x16, mirrored in JS and moq-lite's registry, sent for an unparseable token. Tracks moq-net: a session closed with MALFORMED_AUTH_TOKEN (0x16) reports "unknown code=22" #6567.quest/m0/h265-aspect-backport.md[XS]: backport fix(moq-mux): send the H.265 picture aspect, not the pixel aspect #5574 torelease. Tracks moq-mux H.265 importer puts the VUI sample aspect ratio in the catalog's displayAspectWidth/Height (1:1 SAR shows 16:9 video as square) #6536.quest/m1/auth/ietf-patterns.md[M]: IETF AUTH_OK (draft-lcurley-moq-auth-01) carries lite's pattern strings, so exact and wildcard grants work on draft 17+. Revises the auth epic's prefix-only decision andtoken-in-band.mdto match. Tracks relay auth: on draft 18 an exact-path grant is refused ("grant cannot be encoded as one AUTH_OK"), undocumented #6566.Not imported: #6546 (
export ts --syncwithout an HRD) is resolved by removing--syncin #6554.Decisions
Verified against
mainfirst: 0x16 falls throughfrom_code;Hop::from_wirerefuses >= 2^62; AUTH_OK refuses non-subtree grants; #6536 is already fixed onmainby #5574 but not onrelease.#6545: 64-bit Hop IDs from moqx
#6566: exact-path grants refused on draft 17+
moq auth sign#6567: 0x16 reports
unknown code=22MalformedAuthToken, encoded and sent#6536: H.265 SAR as DAR on
releasereleaseOld lite links and 64-bit hops
IETF AUTH_OK pattern encoding
Placement
Checks:
quest checkpasses.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code