Skip to content

quest: import open issues (64-bit hops, IETF AUTH_OK patterns, 0x16, H.265 aspect backport) - #6580

Merged
kixelated merged 3 commits into
mainfrom
claude/quest-import-issues
Oct 24, 2026
Merged

kixelated merged 3 commits into
mainfrom
claude/quest-import-issues

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Imports the open issues without the quest label. Issues are mentioned without closing keywords; each quest's PR closes its own.

Quests

Not imported: #6546 (export ts --sync without an HRD) is resolved by removing --sync in #6554.

Decisions

Verified against main first: 0x16 falls through from_code; Hop::from_wire refuses >= 2^62; AUTH_OK refuses non-subtree grants; #6536 is already fixed on main by #5574 but not on release.

#6545: 64-bit Hop IDs from moqx

  • Cap Hop IDs at 2^62 - 1 in the draft
  • ✅ Widen Hop to 64 bits
  • Won't fix, close

#6566: exact-path grants refused on draft 17+

  • ✅ Patterns in IETF AUTH_OK
  • Document a subtree-only rule and warn in moq auth sign

#6567: 0x16 reports unknown code=22

  • ✅ Add MalformedAuthToken, encoded and sent
  • Decode only
  • Leave unknown, add a comment

#6536: H.265 SAR as DAR on release

Old lite links and 64-bit hops

  • ✅ Send the hop as 0 (reserved unknown hop)
  • Withhold the route
  • Close the session

IETF AUTH_OK pattern encoding

  • ✅ Lite's pattern strings
  • Track Namespace plus a match kind

Placement

  • ✅ m0: hops, 0x16, backport; m1 auth epic: AUTH_OK patterns
  • All in m1 (backport m0)
  • Backport m0, rest m2

Checks: quest check passes.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d0c56646-4c9e-47f9-951c-ed6ce240bf33
📥 Commits

Reviewing files that changed from the base of the PR and between b103413 and a8fa0ec.

📒 Files selected for processing: 7
  • quest/m0/README.md
  • quest/m0/h265-aspect-backport.md
  • quest/m0/hop-id-64.md
  • quest/m0/malformed-auth-token-code.md
  • quest/m1/auth/README.md
  • quest/m1/auth/ietf-patterns.md
  • quest/m1/auth/token-in-band.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T23:40:10.642006Z a8fa0ec New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 034e7e0ef7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/auth/ietf-patterns.md Resolved
Comment thread quest/m0/malformed-auth-token-code.md Resolved
…ugh moq-auth

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Summary: imports #6545, #6566, #6567, and #6536 as four quests (m0: 64-bit Hop IDs, the 0x16 session code, the #5574 release backport; m1 auth epic: patterns in IETF AUTH_OK), with every decision recorded in the PR body. #6546 is left to #6554, which removes --sync.

Review round 1 (Codex): the AUTH_OK quest now negotiates -01 under a new AUTH Setup Option code point so a -00 peer doesn't misparse it, and the 0x16 quest carries "malformed" through moq-auth's refusal contract to moq-relay (resized to [S]). Codex approved the new head.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 23, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 905e1ce Oct 24, 2026
9 checks passed
@kixelated
kixelated deleted the claude/quest-import-issues branch October 24, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant