Repository navigation
fix(carla): stop calling the removed TrackProducer.flush - #6639
Conversation
#6595 removed media.TrackProducer.flush from the Python bindings, since the catalog now measures jitter from timestamps. The CARLA simulator bridge still called it, so its pyright check fails on main. The diff did not touch demo/carla/sim, so CI never selected the carla module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: drops the removed (Written by Claude Opus 5.5) |
moq-dev/moq#6595 removed
media.TrackProducer.flushfrom the Python bindings, since the catalog now measures jitter from timestamps. The CARLA simulator bridge (demo/carla/sim) still called it, sojust carla checkfails pyright onmain:That diff did not touch
demo/carla/sim, so CI never selected the carla module. Any PR that selects it, such as moq-dev/moq#6617, which changessh/dispatch.shand so runs everything, fails until this lands.This drops the call and the test fake's
flushand its assertion.Public API and wire
None. Demo-only.
Checks
just checkpasses (carla, plus the repository-wide lints).🤖 Generated with Claude Code
(Written by Claude Opus 5.5)