Skip to content

fix(auth): drop the examples' stale clock lint expectations - #6688

Merged
kixelated merged 1 commit into
mainfrom
fix/main-bench-example-lints
Oct 24, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/main-bench-example-lints

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

cargo clippy -p moq-auth --all-targets -- -D warnings fails on main: rs/moq-auth/examples/basic.rs and asymmetric.rs carry #![expect(clippy::disallowed_methods)], but #6298 moved both from SystemTime::now() to moq_clock::wall(), so the expectations are unfulfilled.

Approach

Delete both expectations. The examples now read the clock the way clippy.toml asks, so nothing needs suppressing. A workspace clippy --all-targets finds no other stale expectations; its only other failure is the decode_clock bench, which #6682 fixes.

Why the gate missed it

#5531 narrowed the PR gate's clippy-driver build to --tests, moving bench and example targets to Nightly features. That job currently dies earlier in tokio-features (moq-tokio's Connection::open_request is dead code under one feature shape), so it never reaches its clippy --all-targets step, which masked this break and the bench one.

Impact

  • None: example-only, no public API or wire change.

Checks

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

#6298 moved the moq-auth examples from `SystemTime::now()` to
`moq_clock::wall()`, so their `#[expect(clippy::disallowed_methods)]`
attributes went unfulfilled and `clippy --all-targets -D warnings` fails.
The PR gate builds only `--tests`, so it never linted the examples.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38462848-a1fb-4ebd-b58a-28637d910cd6
Commits

Reviewing files that changed from the base of the PR and between 3818519 and fbed1bf.

Files selected for processing: 2
  • rs/moq-auth/examples/asymmetric.rs
  • rs/moq-auth/examples/basic.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T19:41:38.020523Z fbed1bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit 17bee1d Oct 24, 2026
9 checks passed
@kixelated
kixelated deleted the fix/main-bench-example-lints branch October 24, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant