Repository navigation
fix(auth): drop the examples' stale clock lint expectations - #6688
Conversation
#6298 moved the moq-auth examples from `SystemTime::now()` to `moq_clock::wall()`, so their `#[expect(clippy::disallowed_methods)]` attributes went unfulfilled and `clippy --all-targets -D warnings` fails. The PR gate builds only `--tests`, so it never linted the examples. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
cargo clippy -p moq-auth --all-targets -- -D warningsfails onmain:rs/moq-auth/examples/basic.rsandasymmetric.rscarry#![expect(clippy::disallowed_methods)], but #6298 moved both fromSystemTime::now()tomoq_clock::wall(), so the expectations are unfulfilled.Approach
Delete both expectations. The examples now read the clock the way
clippy.tomlasks, so nothing needs suppressing. A workspaceclippy --all-targetsfinds no other stale expectations; its only other failure is thedecode_clockbench, which #6682 fixes.Why the gate missed it
#5531 narrowed the PR gate's clippy-driver build to
--tests, moving bench and example targets to Nightlyfeatures. That job currently dies earlier intokio-features(moq-tokio'sConnection::open_requestis dead code under one feature shape), so it never reaches itsclippy --all-targetsstep, which masked this break and the bench one.Impact
Checks
cargo clippy --locked --manifest-path rs/moq-auth/Cargo.toml --all-targets -- -D warnings: failed before, passes now.cargo clippy --locked --workspace --exclude moq-net-fuzz --exclude moq-quic-fuzz --all-targets --keep-going -- -D warnings: only thedecode_clockbench fails (fix(mux): split the declared clock out so the decode_clock bench compiles #6682).just check: passes.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code