Skip to content

quest: abandon select-launcher-path (fixed in #6256) - #6713

Closed
kixelated wants to merge 2 commits into
mainfrom
quest/m0/ci/select-launcher-path
Closed

kixelated wants to merge 2 commits into
mainfrom
quest/m0/ci/select-launcher-path

Conversation

@kixelated

@kixelated kixelated commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Abandons quest/m0/ci/select-launcher-path.md: the work is already done.

The ./../local.sh re-exec failure exists only on the unmerged moq-dev/moq#6256 branch; main has no sh/local.sh. That branch already fixed it in 66dd38d: after the cd to the repository root, the re-exec is exec bash sh/local.sh bash sh/rs/select.sh "$@", root-relative (review thread).

Choice made unattended: abandon rather than re-fix, since the bug and its fix land together with #6256.

Public API: none. Wire: none.

Checks: quest check passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 24, 2026 22:39
The re-exec bug exists only on the local-gate branch, which already names
sh/local.sh and sh/rs/select.sh root-relative after its cd (66dd38d).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title select.sh resolves its launcher before cd quest: abandon select-launcher-path (fixed in #6256) Oct 25, 2026
@kixelated
kixelated marked this pull request as ready for review October 25, 2026 05:41
@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 51f69f66-6dd7-43fc-a7c3-e490aa8460ac
Commits

Reviewing files that changed from the base of the PR and between c8b426b and 4f09f1b.

Files selected for processing: 2
  • quest/m0/ci/README.md
  • quest/m0/ci/select-launcher-path.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T05:42:07.330332Z 4f09f1b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 4f09f1b

No actionable bugs found. Removing the obsolete quest and its index entry is sensible: base lacks the problematic launcher re-exec, while #6256 contains the root-relative fix. This changes planning documentation only, not runtime behavior, API or wire format.

Verification: inspected both changed files and relevant launcher code on base and #6256 head. No tests or quest checks run.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging main leaves this PR with an empty diff: #6256 already deleted quest/m0/ci/select-launcher-path.md and its CI epic link when it landed. Nothing is left to merge, so this can be closed as superseded. Leaving the close to the maintainer.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Closing as superseded: #6256 deleted quest/m0/ci/select-launcher-path.md and its link when it merged (5a2f210), so this PR has nothing left to land.

(Written by Claude Opus 5.5)

@kixelated kixelated closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant