Skip to content

quest: plan the uncovered Nightly failures from 10-25 - #6833

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/nightly-uncovered-1026
Oct 26, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/nightly-uncovered-1026

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans quests for the failures in Nightly 40192013303 that no quest or PR covers yet.

Triage

Twelve failures were checked against current main:

  • Already fixed (5): rustdoc links (#6703), the advisories (#6721), the drills and the gate (#6702, #6708), and qmux-bench (#6704).
  • Already covered (4): the moq-net Send overflow and the Python sdist (#6798), loom (#6822), and OBS TSan (quest/m0/nightly/obs-audio-candidate.md).
  • Uncovered, planned here (3):
    • quest/m0/nightly/qmux-ios-dead-code.md [XS]: TcpStats and its callers are gated to Linux and macOS, so the iOS simulator build has no dead code.
    • quest/m0/nightly/relay-tests-features.md [XS]: cargo clippy -p moq-relay --tests --no-default-features passes.
    • quest/m1/test-flakes-2/stuck-window-evicts.md [S]: fixes the macOS race in stuck_window_evicts_the_lower_priority at its cause.

This also deletes quest/m0/nightly/windows-relay-expect.md, because #6821 already merged that fix.

Decisions (2026-10-26, maintainer)

Goal: plan quests only for the 3 uncovered failures, so that once they and the in-flight PRs land, Nightly and Platform pass on main. Right scope?

  • ✅ Yes, the 3 uncovered (Recommended)
  • Also re-check covered ones

How far should #10 (qmux iOS dead code) go?

  • Deny warnings everywhere (Recommended)
  • ✅ Just fix qmux

How should #11 (moq-relay integration tests without feature gates) be handled?

  • ✅ Own XS quest (Recommended)
  • Fold into per-crate gate

What should happen to #6817's duplicate windows-relay-expect quest?

  • ✅ Delete it in this PR (Recommended)
  • Leave it

Public API: none (quest files only). Wire: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Adds quests for the three failures from Nightly 40192013303 that nothing
else covers: qmux dead code on iOS, moq-relay integration tests without
default features, and the macOS stuck-window eviction flake. Deletes the
windows-relay-expect quest, which #6821 already fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a8693867-43e4-4936-b156-baa78fd53d17
Commits

Reviewing files that changed from the base of the PR and between 09da543 and df9be68.

Files selected for processing: 6
  • quest/m0/nightly/README.md
  • quest/m0/nightly/qmux-ios-dead-code.md
  • quest/m0/nightly/relay-tests-features.md
  • quest/m0/nightly/windows-relay-expect.md
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/stuck-window-evicts.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T01:59:16.944992Z df9be68 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: df9be68

No actionable bugs found in this planning-only change. The three separate quests are appropriately scoped: align socket-stat availability and callers with supported platforms, gate integration-test transport usage rather than enabling defaults, and reproduce the eviction race before imposing deterministic ordering. These are simpler than warning suppression or weakening the assertion. Removing the Windows quest is consistent with merged #6821.

Verification: inspected the changed plans, related feature gates/socket-stat callers, the eviction test, and #6821's diff. No builds or tests were run; the macOS race remains a hypothesis to reproduce, not a verified diagnosis.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Adds quest/m0/nightly/qmux-ios-dead-code.md, quest/m0/nightly/relay-tests-features.md, and quest/m1/test-flakes-2/stuck-window-evicts.md, linked from their epics.
  • Deletes quest/m0/nightly/windows-relay-expect.md, fixed by moq-dev/moq#6821.
  • Reviews: Codex gave a thumbs up on df9be68 with no findings, and the OpenAI review had no findings. CodeRabbit was rate-limited.
  • Spot-checked the quest claims against main (09da543): the TcpStats cfg layout and its callers, the relay integration-test field uses, and the eviction test location all match.
  • quest check --base origin/main passes on the head.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 4bcb591 Oct 26, 2026
9 checks passed
@kixelated
kixelated deleted the quest-plan/nightly-uncovered-1026 branch October 26, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant