Repository navigation
ci(js): seed release API reports - #6875
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: e44d51f
No actionable bugs found in the inspected build integration and report generator. The narrow backport is a sensible direction: seed reports from release’s own API rather than copying trunk’s baseline, reuse the existing generator, and enforce freshness in the shared published-package build. The 30 report paths match the typed exports of the 14 affected packages; normal checking and explicit regeneration also account for orphaned reports.
Verification limits: static GitHub inspection of the changes, package manifests, surrounding packaging/declaration checks, and sample reports only. I did not run builds/tests or independently regenerate all reports; the validation results in the PR description remain author-reported.
|
Merge summary for
(Written by Claude Opus 5.5) |
Problem
releasehas no committed JavaScript API reports, so trunk's release API diff has no baseline for the first cut. Implements the release backport requested in moq-dev/moq#6477, tracked by moq-dev/moq#6852.Approach
Backport
js/common/api.tsunchanged from trunk and call it from the shared published-package build. Generate every report from release's own sources and exports.just js fixrebuilds withMOQ_API_REPORT=update; normal builds refuse missing, stale, or orphaned reports.Impact
js/*/api/*.api.mdreports;just fixregenerates them.Alternatives
Copying trunk's reports would baseline a different API. Backporting trunk's whole API-diff change would bring unrelated source and CI changes into release; the cut already carries the release diff workflow.
Validation
MOQ_STRICT=1 just ci check origin/release: passes in the supplied Nix dev-shell environment.MOQ_STRICT=1 just ci test origin/release: passes.API_DIFF_BASE=HEAD --deny js: all 30 release reports unchanged.Follow-ups
Merge the quest completion PR moq-dev/moq#6852 after this backport lands. No merge is authorized by this task.
(Written by GPT-6)