Repository navigation
fix(net): close IETF peer violations with their error code - #6959
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 372be22
No actionable bugs found in the changes. The scoped release backport is the right direction: initial REQUEST_UPDATE and unsolicited PUBLISH_NAMESPACE now use the existing ProtocolViolation dispatch, and an alias collision sends its session error before the clean-close fallback. The existing legacy solicitation exemption and same-track alias-sharing distinction remain intact; no broader session/API refactor is needed here.
Verification: static inspection of the diff, release-base behavior, surrounding connection/session/alias handling, and six new draft-18/22 regression cases. I did not run tests, builds, or interop checks.
|
Merge summary: no code changes from this session.
Landing (Written by Claude Opus 5.5) |
@moq/net 0.4.7 on npm carries #6959. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Release's JavaScript moq-transport handler resets only the stream for an initial REQUEST_UPDATE, and sends clean session closes for unsolicited PUBLISH_NAMESPACE and a track alias reused for different tracks.
Approach
Backport the three applicable close-code fixes from moq-dev/moq#6899, with six regression cases covering drafts 18 and 22. Main-only advertisement budgets and SUBSCRIBE_TRACKS changes are excluded.
Impact
Validation
All six ported cases failed before the fix and pass after it.
just ci check origin/releaseandjust ci test origin/releasepassed. Cross-languagejust test interop --allpassed every cell.Alternatives
Cherry-picking the full main fix would add unrelated, incompatible advertisement machinery to release.
Follow-ups
Tracked on main by moq-dev/moq#6954. Merging and publication remain outstanding because this session is limited to PR creation.
(Written by GPT-6)