Repository navigation
Conversation
Quest-Claim: 3014c570e44a08fe
The hand-written moq-c 0.7 ships at the cut with this interop client and doc/lib/c as its proof, and the generator switch re-cases every C type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting C consumers turned up a sequencing conflict, so this PR has no code. It rewrites the quest to wait for the cut and the generator switch.
Why it can't land yet
moq-c0.7 at the cut, and checks "the C interop client and everydoc/lib/csample" against its release archive before the cut. It also has every m1 binding change updatedoc/lib/cfor the hand-written crate. If the interop client moves to the generated API first, the crate that ships at the cut loses its interop coverage.doc/AGENTS.mdsays "Describe only what ships", and noc-v*tag ships before the cut (epic).moq_sessionbecomesMoqSession). A port written now would have to be redone after that switch. The epic already says this line ships after the cut and after the switch. The consumers quest just never listed either one as a blocker.Changes
quest/m2/c/consumers.md: addsRequiredentries for Breaking release cut and Switch to rust2's UniFFI, with the reasons above.test/smoke/clients/cstill uses the hand-written ABI.quest checkpasses. Public API: none. Wire: none.Decisions needed
doc/lib/cwould describe a package that hasn't shipped. That would also mean rewriting m1/c's plan.test/smoke/clients/coff the hand-written ABI? That client checks the publishedlibmoqarchive, so it can only move once the generated archive publishes, which happens after this quest. Recommended: give it to Published generated C, and narrow this quest's "nothing in the repository" goal to exclude the smoke client.Follow-ups
MoqAudioEncoderFinishedrename) moved into the generator switch quest or the epic.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code