Skip to content

quest: plan follow-ups from #7015 and #7016 - #7103

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/afk-follow-ups
Oct 28, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/afk-follow-ups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans the follow-ups from moq-dev/moq#7016 and moq-dev/moq#7015:

The Node polyfill bugs went to moq-dev/web-transport as moq-dev/web-transport#471.

Decisions

Namespace withdraw:

JS subscriber FETCH:

  • ✅ [M] m1, after JS ranges
  • [M] m2
  • Two quests

Interop gaps: the draft-18 cancel spelling is dropped, since Rust and JS both accept a FIN or a reset as a draft-18 cancel.

  • ✅ [S] m0/ci, drop the cancel item
  • [S] m1, drop the cancel item
  • Both as quests

Public API: none. Wire: none (quest-only).

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: acc377c3-1de7-4a72-8ccd-569ed14999d6
Commits

Reviewing files that changed from the base of the PR and between ab1c8ba and 7ce5ac8.

Files selected for processing: 6
  • quest/m0/ci/README.md
  • quest/m0/ci/out-of-crate-targets.md
  • quest/m1/README.md
  • quest/m1/ietf-withdraw-credit.md
  • quest/m1/interop-coverage/README.md
  • quest/m1/interop-coverage/js-ietf-fetch.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T17:00:15.591820Z 7ce5ac8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: e81b904

No actionable bugs found in these plans. Separating withdrawal/backpressure safety from JS FETCH interoperability keeps the work focused, and deriving out-of-crate targets from Cargo metadata is preferable to a moq-cli special case. The stated gaps match the current publisher write waits, JS subscriber limitations, and branch-selection filters; the plans do not claim those runtime gaps are fixed.

Verification: static inspection of the six changed planning files, referenced prerequisites, and relevant implementation paths only. No tests, builds, or interoperability runs executed.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. Adds three quests (quest/m1/ietf-withdraw-credit.md, quest/m1/interop-coverage/js-ietf-fetch.md, quest/m0/ci/out-of-crate-targets.md) with matching README entries, as settled in the 2026-10-28 interview. Codex reviewed e81b904 with no findings, and quest check --base origin/main passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 28, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 1007692 Oct 28, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/afk-follow-ups branch October 28, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant