Skip to content

quest: the HLS target duration is the join interval - #7112

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/hls-target-interval
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/hls-target-interval

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

moq-dev/moq#7041 left EXT-X-TARGETDURATION open: under the join grid a segment can run up to twice the interval even without an overrun.

Approach

Plan-only. Records the maintainer's 2026-10-28 decision in the consumers quest: the target is the interval, and a longer segment is listed under the overrun rule. Rejected: twice the interval, which doubles every player's hold-back.

Impact

Public API: none. Wire: none.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 68bc6805-da98-4fae-9242-aeb4fe0b189b
Commits

Reviewing files that changed from the base of the PR and between 7c7e1d1 and c8f3bb6.

Files selected for processing: 1
  • quest/m1/time-addressing/consumers.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T16:20:30.683597Z c8f3bb6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: c8f3bb6

No new actionable bugs found in this plan-only change. quest/m1/time-addressing/consumers.md:59–65 closes the target-selection decision left open in the prior #7041 review: ordinary multi-group segments exceeding the interval are now explicitly covered by the overrun policy. This resolves the planning ambiguity, not the acknowledged HLS conformance deviation.

Direction: reusing the existing overrun policy is simpler than adding a second segmentation policy, and the latency/compliance trade-off is explicit. Keep the planned unequal-GOP and rounding-boundary cases when implementing it; client tolerance remains a verification requirement, not a guarantee from this decision.

Verification: static review of the diff, surrounding consumer plan, linked target-duration plan and earlier review history only. No implementation, playback or test execution was performed.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. Plan-only change: quest/m1/time-addressing/consumers.md records the maintainer's 2026-10-28 decision that the HLS target duration is the join interval, with longer segments listed under the overrun rule. It rejects twice the interval, which would double every player's hold-back.

CI is green, Codex found nothing on c8f3bb6, and quest check passes against main.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 14ae278 Oct 28, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/hls-target-interval branch October 28, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant