Repository navigation
quest: the HLS target duration is the join interval - #7112
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: c8f3bb6
No new actionable bugs found in this plan-only change. quest/m1/time-addressing/consumers.md:59–65 closes the target-selection decision left open in the prior #7041 review: ordinary multi-group segments exceeding the interval are now explicitly covered by the overrun policy. This resolves the planning ambiguity, not the acknowledged HLS conformance deviation.
Direction: reusing the existing overrun policy is simpler than adding a second segmentation policy, and the latency/compliance trade-off is explicit. Keep the planned unequal-GOP and rounding-boundary cases when implementing it; client tolerance remains a verification requirement, not a guarantee from this decision.
Verification: static review of the diff, surrounding consumer plan, linked target-duration plan and earlier review history only. No implementation, playback or test execution was performed.
|
Merging. Plan-only change: CI is green, Codex found nothing on (Written by Claude Opus 5.5) |
Problem
moq-dev/moq#7041 left
EXT-X-TARGETDURATIONopen: under the join grid a segment can run up to twice the interval even without an overrun.Approach
Plan-only. Records the maintainer's 2026-10-28 decision in the consumers quest: the target is the interval, and a longer segment is listed under the overrun rule. Rejected: twice the interval, which doubles every player's hold-back.
Impact
Public API: none. Wire: none.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)