Repository navigation
quest: plan follow-ups from the spawn merges - #7208
Conversation
New quests for the regressions, gaps and diagnostics the spawn's PRs found, and folds of smaller findings into the quests that own them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 74840c9
No actionable planning bugs found. Accounting for the already-reviewed #7195 stack, the new work is the cancelled-fill-wait test, covered-cut handling folded into drop-set, and batch32 write costs folded into the single-delivery investigation.
Direction: a minimal test-only hook establishes task release without adding a production timeout; covering copies clearing cuts fits the existing shared disposition model; measuring both write paths together preserves canonical-content/reservation guarantees without assuming they share every optimization. These are appropriately scoped additions rather than parallel mechanisms.
Verification: static inspection of the stack delta, relevant plans, cancellation checks and group write paths, with independent reviews. No tests or benchmarks were run, and historical performance figures were not independently reproduced.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fill-timeout Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit d150204cfcb0a1ee614dc4d6d964169fc842454c.
No actionable planning bugs found in the update. After excluding incoming main changes, the substantive delta replaces the deleted fill-timeout prerequisite with the one-group publisher plan and narrows unknown-range regression coverage to that supported shape. The other reviewed contributions remain equivalent against their respective bases.
Direction: making the one-group narrowing an explicit prerequisite keeps marker scope and tests aligned with the publisher design, rather than implementing obsolete multi-group ordering behavior. The plan still requires both FETCH drafts and the largest-group draft-22 fill to cover a listed group lost before writing.
Verification: static base-aware comparison and inspection of the linked one-group plan. No tests, benchmarks, or interop runs were executed.
Main squashed the #7195 stack this branch carried; take main's copies of its quests and keep this PR's additions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
(Written by Claude Opus 5.5) |
Plans the follow-ups raised while merging the 2026-10-28 spawn's PRs, decided one at a time with the maintainer.
#7195, which this was stacked on, has landed;
mainis merged in, so the diff shows only this PR's changes.Changes
m2/perf/single-delivery-write:write_frames' remaining ~20% per-frame cost from fix(net): preserve transport frame bounds #6922's canonical storage (#7139).m1/drop-set:DropCursor::cutreports a cut that a fetched copy covers (#7053, #7149).Posted as PR comments instead, since open PRs hold those quests:
#[kio::test]can live inkio-macros, on #7027.kio-macrosworkspace-hack entry, on #6985.Decisions
write_framesresidual (perf(net): resolve the paired network microbenchmark regressions #7139): ✅ fold into single-delivery-write · separate [M] m2/perf · skipjust go checkon unformatted Go #7158), idling a hidden camera (feat(publish)!: muted and invisible keep capture open #7157), a loom ARM lane (fix(kio): order a log read before the thread's next epoch pin #7134), and ts::Restart beyond the CLI (feat(mux): a TS clock step restarts the import under a new epoch #7144).quest checkpasses.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code