Skip to content

quest: backport the audio groupDuration to release - #7279

Draft
kixelated wants to merge 2 commits into
mainfrom
quest/m0/backport-audio-group-duration
Draft

kixelated wants to merge 2 commits into
mainfrom
quest/m0/backport-audio-group-duration

Conversation

@kixelated

@kixelated kixelated commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Claims quest/m0/backport-audio-group-duration.md.

Summary

  • Code backport: moq-dev/moq#7290 against release, ready for review. It ports Audio.Encoder's groupDuration from moq-dev/moq#4910 onto release's encoder, with the default of 0, plus tests, docs, and API reports. It has no version bump.
  • The 0.5.4 target is gone. While this quest was being worked, the release-cut agent merged moq-dev/moq#7276, which bumped @moq/publish to 0.5.4 for the Opus DTX backport alone. Release JS then published it: npm view @moq/publish version reports 0.5.4. There was no open bump on release to build on.
  • This PR rewrites the quest to what remains: merge feat(publish): pack several audio frames per group on release (backport #4910) #7290, bump @moq/publish on release, and confirm npm carries groupDuration. The Goal no longer names 0.5.4, and the Plan records the status. It closes nothing yet, so the quest file stays and moq-dev/moq#7267 stays open.

Decisions needed

  1. ✅ Decided by the maintainer, 2026-10-30: merge moq-dev/moq#7290 unbumped. @moq/publish 0.5.5 carries groupDuration in the next combined patch cut on release, along with moq-dev/moq#7389, moq-dev/moq#7298, the dot-segment and auth-redirect backport, Python moq-rs 0.5.2, and Dart moq 0.1.1. The maintainer picks the versions and cuts the release; agents do not bump. This was option B, with 0.5.5 named as the version. moq-dev/moq#7290 is now landing at head 272c4ee48d.

No decisions remain open. What remains is the maintainer's combined cut, then confirming that npm view @moq/publish@0.5.5 carries groupDuration. After that, this quest can be deleted and moq-dev/moq#7267 closed.

Review

Skipped for this PR's diff: it only edits the quest file (status and Goal wording), which quest check --base origin/main validates. The code's review is recorded on moq-dev/moq#7290 (Codex gpt-6.1-sol, medium effort, head bcd6040fd6: one finding refuted as out of scope, then a clean round).

Follow-ups

  • On main, cap audio groups at MAX_GROUP_FRAMES / MAX_GROUP_CACHE_BYTES. A groupDuration of tens of seconds with 2.5 ms Opus frames throws GroupTooLarge. Fix it there, then backport.
  • Release coordination: the release bump agent and backport quests that target a version number can race. Consider having backport quests name "the next release" rather than a specific version.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Backport the audio groupDuration to release quest: backport the audio groupDuration to release Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant