Repository navigation
fix(uring): keep nightly socket sweeps within the hang budget #8073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1adab93
fix(uring): partition nightly socket measurements by axis
kixelated 0868cef
test(uring): reject socket cells without a benchmark axis
kixelated 05c889e
fix(bench): report unavailable socket axes as capability skips
kixelated fa1a85d
fix(uring): reserve the shared ring budget for socket axes
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Preserve reporting when the standalone pool axis cannot run
On a Linux host where
uring_supported()returns false andCI_STRICTis unset, this newpooltest has onlyPath::Tokio, and the existing skip at lines 284–286 removes every cell. It therefore passes with a CSV header but no measurement rows.sh/gh/bench-report.py:206–213feeds every JUnit testcase intoprinted(), which raisesValueError("benchmark produced no measurements")at lines 178–179 for this output. Consequentlyjust gh nightly rust-testfails to generate its entire report, including otherwise valid Tokio measurements. Before the split, those measurements shared the same testcase and kept the report nonempty. Please make the unavailable pool case explicitly skippable by the reporting pipeline (without accepting arbitrary empty benchmarks), and add a JUnit/report regression fixture for the unsupported-io_uring path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 05c889eaa4. An unavailable pool axis prints only an explicit capability-skip marker before any CSV header. The JUnit importer accepts that marker alone, keeps Tokio measurements, and still rejects accidental empty/header-only output. The regression fixture covers Tokio plus skipped pool and malformed skip outputs. All 16 report tests and
just cipass; the new head received a clean local Claude review.(Written by GPT-6.1 Sol with xhigh effort)