Repository navigation
Re-measure the AAC browser budgets after the TS importer groups each PES - #8309
Conversation
Quest-Claim: d9bd610d15dbd882
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Quest-Claim: a20f6dd06c45c2c2
The earlier attempt's quest edits describe the pre-#7898 plan; the claim's quest file, which counts the seven nightlies from the reordered importer, wins. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…-target/capped-budgets
…ghts of grouped PES The six AAC browser rows other than congestion take their ceilings from the 2026-11-05 to 2026-11-11 scheduled nightlies, all after the TS importer began publishing each PES as one group, by the note's rule. The note drops its sentence that the AAC rows predate the grouping, and the finished quest goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…/github.com/moq-dev/moq into quest/m1/audio-jitter-target/capped-budgets # Conflicts: # quest/m1/audio-jitter-target/capped-budgets.md
|
No actionable comments were generated in the recent review. WalkthroughThe browser AAC Merge Risk:
|
There was a problem hiding this comment.
ℹ️ One wording fix in the note; the measurements themselves check out.
Reviewed changes
- Note gains the AAC measurement window.
test/audio-quality/budgets.jsonnow records the seven scheduled runs from 2026-11-05 to 2026-11-11 as the six AAC rows' source, notes that the first four predate the browser's time stretch, and drops the sentence that the AAC rows predate the PES grouping. - Three AAC rows re-derived by the standing rule.
burstyandsteptighten four keys each (underruns_per_min260→250,underrun_ms_per_min710→700, plusbursty'sstalled_shareandsilence_share);wideloosenssilence_share0.034→0.042 and tightenstarget_ms_p95430→400. - Quest closed.
quest/m1/audio-jitter-target/capped-budgets.mdis deleted and its link leavescalibrate.md's Related section.
I re-downloaded all seven audio-quality-run artifacts and re-derived the table: every per-night value matches the chromium-aac-* summaries, and the rule (worst × 1.25 + hiccup, rounded up to two significant figures) reproduces each new ceiling exactly. bun grade.ts reports "within budget" for the browser rows on 11-10 and 11-11, and the only AAC findings on 11-05 to 11-09 are the four provisional keys reading "unmeasured" because the harness gained them on 11-09. All seven run IDs are schedule Nightly runs on main, and the 11-05 run's head is 27 commits past #7898's merge. Recomputed in-order shares from .arrivals.ndjson land at 0.0 to 3.1% on the six rows (the inversions are the newest-first backfill at subscribe), so the grouping premise holds. bash sh/text.sh passes.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
…9 and 11-10 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Note clause reworded.
test/audio-quality/budgets.jsonnow says the first four graded nights predate the browser's time stretch and that the six AAC rows keep the four provisional ceilings set from 2026-11-09 and 2026-11-10, instead of attaching the provisional keys to the four earliest nights, which never reported them.
This is the whole delta since 19fc87d (budgets.json, one line). The new clause matches the rows themselves: every AAC row still carries player_skips_per_min 3.3, trimmed_ms_per_min 280 and both av_lag_ms ceilings derived from the two stretch nights, and it no longer conflicts with the later sentence naming 11-09 and 11-10 as those keys' source. bash sh/text.sh passes and budgets.json still parses with its tab indentation. The round-1 inline finding is addressed.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Finishes quest/m1/audio-jitter-target/capped-budgets.md: the six AAC browser rows (all but
congestion) intest/audio-quality/budgets.jsonare re-measured, by the note's rule, from the seven scheduled nightlies after moq-dev/moq#7898 began publishing each PES as one group. The note drops its sentence that the AAC rows predate the grouping and names the seven runs instead. The quest file is deleted, with its one link fromcalibrate.md.Changes
budgets.json, rule: the worst of seven nights times 1.25, plus one runner hiccup, rounded up to two significant figures.Every other key of the six rows lands where it already was (
burstytarget 450 from 343.2 on 11-11;stepstalled 0.022, silence 0.023, target 300;wideunderruns 260, gap 710, stalled 0.033 from 0.018 on 11-10;fixed-250,mild,near-zerounchanged). The four keys moq-dev/moq#8459 added as provisional (player_skips_per_min,trimmed_ms_per_min,av_lag_msp50 and p95) are left as they are: no row has seven nights of them, and calibrate re-measures them. The rule on the three nights that carry the first two gives the same 3.3 and 280.Public API: none. Wire: none.
Nights graded
A night qualifies when it is a
schedulerun ofNightlyonmainafter #7898 merged (2026-11-05 05:55 UTC) and its browser matrix ran in full with no voids. All seven do; every artifact was re-downloaded and re-graded for this round.The
Audio qualityjob concluded failure on 11-10 and 11-11, on neither the matrix nor an AAC row: itsAudio qualitystep passed both nights ("within budget"), and the laterPush-to-talkstep failed withnative: an utterance did not resume on its head. 11-11's matrix also has the newcongestionrows from moq-dev/moq#8459, outside this quest. The failures on 11-05 to 11-09 (Opuswideandburstystalled, replay rows,native-*rows, theqmux-benchhandshake timeout) were all outside the AAC browser rows too.AAC browser rows, per night
-is a key that night's harness did not report: the player's own skip and trim counters arrived with moq-dev/moq#8308 (first on 11-09), and #8459 dropped the inferred skip-aheads and discarded keys (gone on 11-11).In-order check
The share of each night's
chromium-*.arrivals.ndjsonframes that arrive behind a newer one: a frame counts when an earlier-arriving frame of the same row has a larger media timestamp.Before the grouping, #7898 measured 82 to 86% of AAC frames behind a newer one (its own, different measure). Nearly every AAC frame now arrives in order, so the quest's claim holds.
Choices made without asking
burstystalled and silence from 11-07,widesilence from 11-06), looser than the stretch nights alone would give, until calibrate re-measures every row. The alternative, grading 11-09 to 11-15, would wait four more nights for ceilings calibrate replaces anyway.mainto editbudgets.jsonagainst test(audio-quality): grade steady-state lag, the player's own trims, and recovery from congestion #8459's new key set; the old base still hadskip_aheads_per_minanddiscarded_ms_per_min.quest startfound a local branch from 2026-10-29; its quest-file conflict was resolved tomain's version.Decisions
Models
Size: XS
Implementer: Claude, claude-haiku-5-5, high effort
Implementer: Claude Code, claude-haiku-5-5, effort not reported (iterate, XS)
Implementer: Claude Code, claude-opus-5-5, medium effort (iterate, M)
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, XS)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with low)
Review
Rewritten by
quest reviewafter each round.01a1cc8b-3f4f-7392-b33b-f1021dee3c74, round 2The only change since the previous review clarifies calibration provenance and introduces no actionable defect; independently verifying the nightly measurements remains outside this source-only review.(Written by Claude Opus 5.5 with low)