Repository navigation
fix(net): the route node's feeder is built from origin-wide state only #8401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kixelated
merged 5 commits into
main
from
quest/m2/cluster-routing/routes/node-creation-order
Nov 10, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1b72b3b
chore(quest): claim quest/m2/cluster-routing/routes/node-creation-ord…
kixelated 0fd5845
fix(net): the route node's feeder is built from origin-wide state only
kixelated 6212e43
test(moq-net): make the route-node creator levers bite
kixelated df0b543
Merge remote-tracking branch 'origin/main' into node-creation-order
kixelated 25bec4c
Merge origin/main; drop finished quest from epic Required
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with_hidden(false)is the default, and the only claim announced below isroom/alice, which has no.segment, so a feeder that inheritedhidden.include = falsewould still serve it and this assertion would pass — I confirmed by leakingself.hiddeninto the literal. The quest's failing case was a hidden route (room/.server/bob) staying routable, so announcing that path would make the hidden reset actually bite (it fails with the leak and passes withinclude: true).with_proxy(true)cannot bite the same way: the feeder'sTableCursorholds noproxyfield, so it documents the handle rather than testing a lever.