Repository navigation
quest: plan the C bindings accepting MoqInstance - #8416
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: 34591c4
Base: 1e8717a
[P2] Investigate the selected generator before removing exported traits
Location: quest/m0/check-c-moqinstance.md:19–22
The proposed repair assumes the current C generator cannot render these traits, but this head already pins v0.11.0-kixelated.8+v0.32.2 in flake.nix:433 and commit 6ea9f9bb764e2f9e753ff2bb623e899598df7960 in .github/actions/uniffi-bindgen/action.yml:24. That exact generator renders Debug, Display, Eq and Hash. #8366 also records this same failure from a stale CMake cache selecting kixelated.7, followed by a passing check after clearing it.
Keep the m0 goal, but first verify the failing build's resolved UNIFFI_BINDGEN_CPP and reproduce with a fresh build directory and the pinned generator. c/moq/CMakeLists.txt:15 uses cached find_program resolution. Otherwise the plan can remove a working cross-binding API or reimplement an existing fix while missing the actual tool-selection problem. Removing only Debug would not help the older generator either: it rejects the remaining exported traits too.
Verification limits: GitHub-only source, tag and history inspection. I did not reproduce the local build failure or run checks.
|
This run was cancelled before it finished. |

Plans a fix for
just check'scheck c, which fails onmainsince moq-dev/moq#8366: the C bindings generator refusesMoqInstance's exportedDebugtrait (#[uniffi::export(Debug, Display, Eq, Hash)]inrs/moq-ffi/src/instance.rs). Every branch's local check fails on it. Found by moq-dev/moq#8375's iterate.Changes
quest/m0/check-c-moqinstance.md[XS], linked from the m0 README.Decisions
mainjoin m0.Checks
quest check: pass.Impact
Public API: none. Wire: none.
Models
Size: XS
Implementer: Claude Code, Opus 5.5, high effort
(Written by Opus 5.5 with high effort)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.01a1c3b6-c1f8-7a83-a4dc-d7fbc36a8daf, round 1The change only records and links a follow-up quest, introduces no executable changes or actionable defects, and clearly states the problem, alternatives, and potential API impact.