Skip to content

quest: plan the C bindings accepting MoqInstance - #8416

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/check-c-moqinstance
Nov 10, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/check-c-moqinstance

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Plans a fix for just check's check c, which fails on main since moq-dev/moq#8366: the C bindings generator refuses MoqInstance's exported Debug trait (#[uniffi::export(Debug, Display, Eq, Hash)] in rs/moq-ffi/src/instance.rs). Every branch's local check fails on it. Found by moq-dev/moq#8375's iterate.

Changes

  • New quest/m0/check-c-moqinstance.md [XS], linked from the m0 README.

Decisions

Checks

  • quest check: pass.

Impact

Public API: none. Wire: none.

Models

Size: XS
Implementer: Claude Code, Opus 5.5, high effort

(Written by Opus 5.5 with high effort)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1c3b6-c1f8-7a83-a4dc-d7fbc36a8daf, round 1
  • Head: 34591c4
  • Base: origin/main at 1e8717a
  • Score: 10/10, The change only records and links a follow-up quest, introduces no executable changes or actionable defects, and clearly states the problem, alternatives, and potential API impact.
  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 10, 2026 04:33
@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 99445875-ff20-42a6-b578-93e8a46b4092
Commits

Reviewing files that changed from the base of the PR and between 1e8717a and 34591c4.

Files selected for processing: 2

  • quest/m0/README.md
  • quest/m0/check-c-moqinstance.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 34591c4
Base: 1e8717a

[P2] Investigate the selected generator before removing exported traits
Location: quest/m0/check-c-moqinstance.md:19–22

The proposed repair assumes the current C generator cannot render these traits, but this head already pins v0.11.0-kixelated.8+v0.32.2 in flake.nix:433 and commit 6ea9f9bb764e2f9e753ff2bb623e899598df7960 in .github/actions/uniffi-bindgen/action.yml:24. That exact generator renders Debug, Display, Eq and Hash. #8366 also records this same failure from a stale CMake cache selecting kixelated.7, followed by a passing check after clearing it.

Keep the m0 goal, but first verify the failing build's resolved UNIFFI_BINDGEN_CPP and reproduce with a fresh build directory and the pinned generator. c/moq/CMakeLists.txt:15 uses cached find_program resolution. Otherwise the plan can remove a working cross-binding API or reimplement an existing fix while missing the actual tool-selection problem. Removing only Debug would not help the older generator either: it rejects the remaining exported traits too.

Verification limits: GitHub-only source, tag and history inspection. I did not reproduce the local build failure or run checks.

Merged via the queue into main with commit beb9013 Nov 10, 2026
9 of 10 checks passed
@kixelated
kixelated deleted the quest-plan/check-c-moqinstance branch November 10, 2026 04:41
@pullfrog

pullfrog Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

This run was cancelled before it finished.

Pullfrog  | View workflow run | via Pullfrog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant