Skip to content

quest: Nightly's qmux benchmark handshake is already fixed - #8427

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/nightly/qmux-bench-handshake
Nov 10, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/nightly/qmux-bench-handshake

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/nightly/qmux-bench-handshake.md by deleting it: the regression is already fixed on main.

Summary

The scheduled Nightly's just js qmux-bench step timed out on the handshake from 2026-11-07 on. The cause was moq-dev/moq#8054: Session.ready started waiting for the peer's transport parameters, and the benchmark's fake peer never sent any. moq-dev/moq#8351 (merged 2026-11-09 18:00 UTC) made the fake peer a real Session.accept, so it sends its parameters. The last failing Nightly (run 42659882487, head b3fbce18) predates that merge, and no Nightly has run since.

Local repro on current main: just js qmux-bench passes all 12 rows (eager ~5.6 ms / lazy ~22 ms at 0 ms latency, ~56 / ~123 ms at 50 ms).

This PR only removes the quest and its link in quest/m0/nightly/README.md. Public API: none. Wire: none.

Caused by

Choices made without asking

  • Did not dispatch a Nightly to confirm; the local run exercises the same step, and the next scheduled Nightly will.

Review

Skipped: the diff only deletes a finished quest and its link; quest check passes (503 documents ok). just check not run, since no code changed.

Models

Size: S
Implementer: Claude Code, Claude Opus 5.5, low effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with low)

kixelated and others added 2 commits November 10, 2026 01:12
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Nightly's WebSocket fallback benchmark connects again quest: Nightly's qmux benchmark handshake is already fixed Nov 10, 2026
@kixelated
kixelated marked this pull request as ready for review November 10, 2026 10:14
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Nightly README no longer lists the WebSocket fallback benchmark handshake requirement, including its timeout and Audio quality job outcome description. The qmux-bench handshake-timeout investigation document was deleted.

Estimated code review effort:

Merge Risk: Minimal · up to 19071

This PR removes a stale tracking document for a benchmark handshake issue that the author reports is already fixed. It does not change runtime behavior, and there is no actionable merge risk.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title identifies the qmux benchmark handshake issue and states that it is fixed, which explains why the related quest is removed.
Description check Passed The description explains the handshake timeout, the reported fix, and the removal of the quest and its link.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e5aa71a8-27b0-4c60-b3a2-1e43a8de338b
Commits

Reviewing files that changed from the base of the PR and between cd560bd and 19071ad.

Files selected for processing: 2

  • quest/m0/nightly/README.md
  • quest/m0/nightly/qmux-bench-handshake.md
Files with no reviewable changes: 2

  • quest/m0/nightly/README.md
  • quest/m0/nightly/qmux-bench-handshake.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Quest deletion — quest/m0/nightly/qmux-bench-handshake.md is removed in full; the slug no longer appears anywhere in the tree, so nothing dangles.
  • Epic README link — the matching ## Required bullet in quest/m0/nightly/README.md is removed, leaving macos.md and windows.md.

Verified the premise against the tree rather than the body: js/net/bench/qmux.ts now builds its fake peer with Session.accept, whose comment records that it sends transport parameters first, which is exactly the cause #8054 introduced and #8351 fixed. Grepping the checkout for qmux-bench-handshake returns no matches, and the Quest job passed, so quest check is clean on the reduced tree. #8351 also deleted its own parallel quest for the same failure, so this removes the duplicate that #8408 planned after the fix had already landed.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit 19071ad.

No actionable defects found in the two-file documentation cleanup. The deleted quest's corresponding Required link is removed, and the benchmark at this commit uses Session.accept for its server peer, consistent with the stated handshake fix. Overall direction: retiring this completed task looks sound; no runtime code changes are included.

Verification limits: GitHub source/diff review only. I did not run quest check, the benchmark, or Nightly, and have not independently confirmed the reported timing results.

@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 5e962fc Nov 10, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m0/nightly/qmux-bench-handshake branch November 10, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant