Repository navigation
chore(quest): delete the check c MoqInstance quest as not reproducible - #8430
Conversation
Quest-Claim: 93b940cd81e59f37
`check c` passes on main through the real dispatcher, so there is no refusal to fix. The generator renders MoqInstance's exported Debug, and instance.rs and flake.lock have not changed since #8366. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed the complete two-file patch at 378b913. No actionable findings.
Direction: the change removes the abandoned investigation and its matching index entry without changing the generator, exported traits, or executable behavior. This matches the deletion decision recorded in the PR rather than removing functionality to work around an unreproduced failure.
Verification limits: GitHub-only static review. I did not run the C/C++/OBS checks or independently reproduce the reported passing generator output; those remain author-provided evidence.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Deleted
quest/m0/check-c-moqinstance.md— the[XS]quest premised oncheck cfailing because the C generator refusesMoqInstance's exportedDebug, which the evidence in the PR body refutes onmain. - Dropped its bullet from
quest/m0/README.md— the only link to the quest in the tree.
The deletion follows the convention from #8423 (delete the file and its milestone README bullet, no tombstone). I verified there are no dangling references: grep -rn check-c-moqinstance and grep -rn "MoqInstance again" return nothing tree-wide, a link check over all 503 quest/**/*.md files reports zero broken targets, and no doc, CI, or skill file mentions the quest. No open issue or PR depends on it, so nothing in flight is discarded.
One thing I could not re-run here: this sandbox has no nix, just, or uniffi-bindgen-cpp, so check c was taken from the PR body rather than reproduced. Nothing in the tree contradicts it — rs/moq-ffi/src/instance.rs:14 still carries #[uniffi::export(Debug, Display, Eq, Hash)], and the lone post-#8366 git log hit on that file is the shallow clone's graft boundary (fb0d5a267), not a real change.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Deletes quest/m0/check-c-moqinstance.md as not reproducible, and its one link in
quest/m0/README.md.Decision
Maintainer, 2026-11-10: delete the quest as not reproducible. The premise was that the C generator refuses
MoqInstance's exportedDebug, socheck cfails on every branch. That does not hold on main.Evidence
check cpasses on main through the real dispatcher:CHECK_MODULES=c just check --allreportscheck c passed.check con main, per the maintainer.moq.hdeclaresmoq_instance_to_debug_string, so thekixelated/uniffi-bindgen-cppfork handles it..github/actions/uniffi-bindgenpins the commit that tagv0.11.0-kixelated.8+v0.32.2peels to, andflake.nixuses that tag.c734d2aa16) touchesrs/moq-ffi/src/instance.rsorflake.lock.cppandobs_compilealso pass on main.Checks
quest checkandquest check --base origin/main:503 documents ok.Review
Rewritten by
quest reviewafter each round.01a1c807-54ef-7821-a38a-5fdb9bfa8799, round 1The diff only deletes the unreproducible C-bindings quest and its index entry, changes no runtime code or tests, and leaves no references to the deleted quest.Public API and wire
None.
Models
Size: XS
Implementer: Claude Code, Haiku 5.5, high effort
(Written by Haiku 5.5 with high)