Skip to content

chore(quest): delete the check c MoqInstance quest as not reproducible - #8430

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/check-c-moqinstance
Nov 11, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/check-c-moqinstance

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes quest/m0/check-c-moqinstance.md as not reproducible, and its one link in quest/m0/README.md.

Decision

Maintainer, 2026-11-10: delete the quest as not reproducible. The premise was that the C generator refuses MoqInstance's exported Debug, so check c fails on every branch. That does not hold on main.

Evidence

  • check c passes on main through the real dispatcher: CHECK_MODULES=c just check --all reports check c passed.
  • Other agents' full runs also pass check c on main, per the maintainer.
  • The generator renders the export: moq.h declares moq_instance_to_debug_string, so the kixelated/uniffi-bindgen-cpp fork handles it.
  • CI and the dev shell build the same generator: .github/actions/uniffi-bindgen pins the commit that tag v0.11.0-kixelated.8+v0.32.2 peels to, and flake.nix uses that tag.
  • No commit since moq-dev/moq#8366 (c734d2aa16) touches rs/moq-ffi/src/instance.rs or flake.lock.
  • cpp and obs_compile also pass on main.

Checks

  • quest check and quest check --base origin/main: 503 documents ok.

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1c807-54ef-7821-a38a-5fdb9bfa8799, round 1
  • Head: 378b913
  • Base: origin/main at 88572c5
  • Score: 10/10, The diff only deletes the unreproducible C-bindings quest and its index entry, changes no runtime code or tests, and leaves no references to the deleted quest.
  • Findings: none

Public API and wire

None.

Models

Size: XS
Implementer: Claude Code, Haiku 5.5, high effort

(Written by Haiku 5.5 with high)

kixelated and others added 2 commits November 10, 2026 01:13
`check c` passes on main through the real dispatcher, so there is no
refusal to fix. The generator renders MoqInstance's exported Debug, and
instance.rs and flake.lock have not changed since #8366.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The C bindings accept MoqInstance again chore(quest): delete the check c MoqInstance quest as not reproducible Nov 10, 2026
@kixelated
kixelated marked this pull request as ready for review November 10, 2026 16:54
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1cb066b6-a58b-456a-9a4f-e0e0776dd946
Commits

Reviewing files that changed from the base of the PR and between cd560bd and 378b913.

Files selected for processing: 2

  • quest/m0/README.md
  • quest/m0/check-c-moqinstance.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed the complete two-file patch at 378b913. No actionable findings.

Direction: the change removes the abandoned investigation and its matching index entry without changing the generator, exported traits, or executable behavior. This matches the deletion decision recorded in the PR rather than removing functionality to work around an unreproduced failure.

Verification limits: GitHub-only static review. I did not run the C/C++/OBS checks or independently reproduce the reported passing generator output; those remain author-provided evidence.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted quest/m0/check-c-moqinstance.md — the [XS] quest premised on check c failing because the C generator refuses MoqInstance's exported Debug, which the evidence in the PR body refutes on main.
  • Dropped its bullet from quest/m0/README.md — the only link to the quest in the tree.

The deletion follows the convention from #8423 (delete the file and its milestone README bullet, no tombstone). I verified there are no dangling references: grep -rn check-c-moqinstance and grep -rn "MoqInstance again" return nothing tree-wide, a link check over all 503 quest/**/*.md files reports zero broken targets, and no doc, CI, or skill file mentions the quest. No open issue or PR depends on it, so nothing in flight is discarded.

One thing I could not re-run here: this sandbox has no nix, just, or uniffi-bindgen-cpp, so check c was taken from the PR body rather than reproduced. Nothing in the tree contradicts it — rs/moq-ffi/src/instance.rs:14 still carries #[uniffi::export(Debug, Display, Eq, Hash)], and the lone post-#8366 git log hit on that file is the shallow clone's graft boundary (fb0d5a267), not a real change.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 1a8be1c Nov 11, 2026
13 of 14 checks passed
@kixelated
kixelated deleted the quest/m0/check-c-moqinstance branch November 11, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant