Skip to content

fix(interop): refresh staging fixture and released wire baseline - #8455

Merged
kixelated merged 2 commits into
mainfrom
fix/interop-scheduled-failures
Nov 11, 2026
Merged

kixelated merged 2 commits into
mainfrom
fix/interop-scheduled-failures

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Scheduled Interop fails because its staging Cargo mock lacks the dependency lookup used by the released hang adapter, and its released-wire baseline pins are stale.

Approach

Add the adapter's Cargo dependency lookup to the staging mock. Remeasure against the newest installable releases: moq-cli 0.14.15, moq-relay 0.17.15, and @moq/net 0.4.7. Refresh the measurement date while retaining the existing unpublished lite-07-wip exception.

Impact

  • No public API or wire changes. Stable lite-01 through lite-06 compatibility passes.

Validation

All commands ran in the Nix development shell and finished in the foreground.

  • Reproduced the original staging exit 2 without the Cargo tree mock; all six staging tests pass with it.
  • quest gate just test wire-compat --remeasure: passed; 89 session cells ran, 32 skipped. The existing lite-07-wip exception still fails 16 of 17 measured cells; its FETCH capability cell passes.
  • quest gate just check: passed.
  • quest gate just ci: passed.
  • quest gate just test interop --all: passed, including cross-language media and finite track tails.

Remeasure output from this checkout on 2026-11-11:

"moq-cli": "0.14.15",
"moq-relay": "0.17.15",
"@moq/net": "0.4.7",
session cells: 89 ran, 32 skipped
moq-lite-07-wip: still fails in 16 of 17 cells; re-pinned
wire compatibility: token, session, catalog, and container lanes passed

Decisions

  • Maintainer approved takeover on 2026-11-11 and selected /quest-merge; the coordinator handles queueing after independent review and readiness.
  • No base merge needed: the branch is conflict-free.

Alternatives

Keep strict stale-pin validation and measure releases rather than hand-editing pins without evidence.

Follow-ups

No new follow-up recommended. The existing unpublished lite-07-wip exception remains measured and unchanged in scope. This enables the scheduled Interop pass awaited by moq-dev/moq#8347.

Caused by

  • moq-dev/moq#8247 - added the adapter's Cargo dependency lookup without updating the staging mock.
  • Baseline staleness follows new upstream package releases; no single PR caused it.

Models

Size: M
Implementer: Codex, gpt-6.1-sol, unknown effort
Implementer: Codex, gpt-6.1-sol, high effort (iterate, S)

Review

Rewritten by quest review after each round.

  • Reviewer: Claude Code, claude-opus-5-5, medium effort
  • Session: 4d0b3888-b720-4cb0-99f0-810eafa4aea1, round 1
  • Head: ae1125c, named in full once a round reports no findings
  • Base: origin/main at 1c7b84c
  • Score: 8/10, This is a narrow test fix plus a refresh of the version pins, and both fit how the harness reads them; the pins couldn't be checked against the published releases because reading git tags was denied.
  • Findings, open until the next round settles them:
    • Low, test/interop/compat/planned-breaks.json:5: Re-pinned versions and remeasure claim lack evidence
    • Low, test/interop/staging.test.py:48: Fake `cargo tree` ignores its arguments
    • Low, test/interop/staging.test.py:205: Sliced compat.sh copy with strict fakes keeps breaking

Final disposition at head ae1125c (all findings low; next finish requires no further round):

  1. Addressed: the Validation section now includes the actual remeasure output naming the resolved versions and cell counts. The registry selection in compat/resolve.ts:202-218 reads crates.io/npm, not git tags; the full run exited 0 against exactly these releases.
  2. Refuted: staging.test.py:177-217 tests that staged binaries survive removal of the build target. The fake supplies dependency lookup output so the real compat.sh:139 parsing runs; it does not claim to test Cargo argument semantics. The real released adapter build and 89-cell wire run passed. Adding exact argument assertions would mirror the command rather than verify artifact ownership.
  3. Refuted: failing on unsupported fixture commands is intentional (staging.test.py:65), consistent with the workspace requirement to fail on unsupported input. Accepting unknown read-only subcommands silently would let a missing cargo tree output pass unnoticed. A new override abstraction adds machinery for one mock response; the existing test correctly exposed the stale fixture, and the one-line fix restores the intended ownership check.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review November 11, 2026 10:03
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 924113a3-60d8-4147-a186-a2441b777919
Commits

Reviewing files that changed from the base of the PR and between 554ac7d and ae1125c.

Files selected for processing: 2

  • test/interop/compat/planned-breaks.json
  • test/interop/staging.test.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Staging fixture gains a cargo tree response — test/interop/staging.test.py:48 echoes moq-net v0.1.0, which compat.sh:139 parses to 0.1.0 and matches the bun stub's resolved versions, restoring test_wire_compat_adapters_and_current_binaries_are_owned. Verified locally with uv on PATH.
  • moq-lite-07-wip baseline re-pinned — test/interop/compat/planned-breaks.json moves to moq-cli 0.14.15 and moq-relay 0.17.15, keeps @moq/net 0.4.7, and updates the measurement date to 2026-11-11. Checked against the crates.io sparse index and the npm latest dist-tag: all three are the newest stable releases, so resolve.ts's stale() check will accept them.

The change is test-harness only, with no wire or public API surface. The next upstream release will make the pin stale again, which is the intended --remeasure trigger.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit bf11487 Nov 11, 2026
9 of 10 checks passed
@kixelated
kixelated deleted the fix/interop-scheduled-failures branch November 11, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant