Repository navigation
fix(interop): refresh staging fixture and released wire baseline - #8455
Merged
Merged
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
kixelated
marked this pull request as ready for review
November 11, 2026 10:03
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Staging fixture gains a
cargo treeresponse —test/interop/staging.test.py:48echoesmoq-net v0.1.0, whichcompat.sh:139parses to0.1.0and matches thebunstub's resolved versions, restoringtest_wire_compat_adapters_and_current_binaries_are_owned. Verified locally withuvonPATH. moq-lite-07-wipbaseline re-pinned —test/interop/compat/planned-breaks.jsonmoves to moq-cli0.14.15and moq-relay0.17.15, keeps@moq/net0.4.7, and updates the measurement date to 2026-11-11. Checked against the crates.io sparse index and the npmlatestdist-tag: all three are the newest stable releases, soresolve.ts'sstale()check will accept them.
The change is test-harness only, with no wire or public API surface. The next upstream release will make the pin stale again, which is the intended --remeasure trigger.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Scheduled Interop fails because its staging Cargo mock lacks the dependency lookup used by the released hang adapter, and its released-wire baseline pins are stale.
Approach
Add the adapter's Cargo dependency lookup to the staging mock. Remeasure against the newest installable releases: moq-cli 0.14.15, moq-relay 0.17.15, and @moq/net 0.4.7. Refresh the measurement date while retaining the existing unpublished lite-07-wip exception.
Impact
Validation
All commands ran in the Nix development shell and finished in the foreground.
quest gate just test wire-compat --remeasure: passed; 89 session cells ran, 32 skipped. The existing lite-07-wip exception still fails 16 of 17 measured cells; its FETCH capability cell passes.quest gate just check: passed.quest gate just ci: passed.quest gate just test interop --all: passed, including cross-language media and finite track tails.Remeasure output from this checkout on 2026-11-11:
Decisions
/quest-merge; the coordinator handles queueing after independent review and readiness.Alternatives
Keep strict stale-pin validation and measure releases rather than hand-editing pins without evidence.
Follow-ups
No new follow-up recommended. The existing unpublished lite-07-wip exception remains measured and unchanged in scope. This enables the scheduled Interop pass awaited by moq-dev/moq#8347.
Caused by
Models
Size: M
Implementer: Codex, gpt-6.1-sol, unknown effort
Implementer: Codex, gpt-6.1-sol, high effort (iterate, S)
Review
Rewritten by
quest reviewafter each round.4d0b3888-b720-4cb0-99f0-810eafa4aea1, round 1This is a narrow test fix plus a refresh of the version pins, and both fit how the harness reads them; the pins couldn't be checked against the published releases because reading git tags was denied.test/interop/compat/planned-breaks.json:5:Re-pinned versions and remeasure claim lack evidencetest/interop/staging.test.py:48:Fake `cargo tree` ignores its argumentstest/interop/staging.test.py:205:Sliced compat.sh copy with strict fakes keeps breakingFinal disposition at head ae1125c (all findings low;
next finishrequires no further round):compat/resolve.ts:202-218reads crates.io/npm, not git tags; the full run exited 0 against exactly these releases.staging.test.py:177-217tests that staged binaries survive removal of the build target. The fake supplies dependency lookup output so the realcompat.sh:139parsing runs; it does not claim to test Cargo argument semantics. The real released adapter build and 89-cell wire run passed. Adding exact argument assertions would mirror the command rather than verify artifact ownership.staging.test.py:65), consistent with the workspace requirement to fail on unsupported input. Accepting unknown read-only subcommands silently would let a missingcargo treeoutput pass unnoticed. A new override abstraction adds machinery for one mock response; the existing test correctly exposed the stale fixture, and the one-line fix restores the intended ownership check.