Skip to content

test(kt): quarantine the flaky playout-delay smoke test - #8462

Merged
kixelated merged 1 commit into
mainfrom
test/kt-playout-delay-quarantine
Nov 10, 2026
Merged

kixelated merged 1 commit into
mainfrom
test/kt-playout-delay-quarantine

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Quarantines the Kotlin smoke test audio consumer reports its playout delay with @Ignore and plans its investigation as Kotlin's playout-delay smoke test holds up under load in the m0 test-flakes epic. While iterating moq-dev/moq#8395, which doesn't touch it, the test failed once with a coroutine timeout in a full just check, then passed twice.

Decisions

  • ✅ Quarantine now and plan an m0 quest (rejected: wait for a CI failure), under the repository's flaky-test rule.

Impact

Public API: none. Wire: none. One test is skipped until the quest fixes it.

Checks

just kt check passes; quest check passes (509 documents).

Review

Skipped on head 9291b6390c14190caa683dcb652cfcda0577b3cb: a one-annotation test quarantine plus a new quest file, too small for a review round.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, medium effort

(Written by Claude Opus 5.5 with medium effort)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 937c20f9-9ec9-49ea-af82-d48a53e3afdb
Commits

Reviewing files that changed from the base of the PR and between 8c26d5b and 9291b63.

Files selected for processing: 3

  • kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt
  • quest/m0/test-flakes-2/README.md
  • quest/m0/test-flakes-2/kt-playout-delay.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed the complete patch at 9291b63 and the surrounding Kotlin test. No actionable findings.

Direction: this narrowly quarantines the reported test using kotlin.test.Ignore and links a follow-up that requires reproducing the failure, fixing its cause, and restoring coverage. It follows the repository's immediate-quarantine rule; this change does not establish the timeout's root cause or fix the playout-delay behavior.

Verification limits: GitHub-only static review. I did not reproduce the timeout or run Kotlin/Quest checks; the reported passing runs were not independently verified.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the @Ignore quarantine, its new child quest, and the epic link that tracks it.

  • @Ignore on audio consumer reports its playout delay — kotlin.test.Ignore compiles and skips on both JVM and Android unit tests (kt/ sets no useJUnitPlatform(), so it resolves to org.junit.Ignore), and the test body plus KDoc are untouched, so removing the annotation at fix time is a one-line change.
  • Epic ## Required link — the bullet's wording matches the sibling children (… and its @Ignore is removed), and the absolute /quest/... link matches the existing entries.
  • kt-playout-delay.md — records the trigger (one coroutine timeout in a loaded full just check while iterating #8395, two subsequent passes), names the exact test and file, and follows the epic's rules for the eventual fix (Public API: none. Wire: none. present).

The quarantine itself matches AGENTS.md's "immediately disable a flaky test and plan a follow-up to investigate", and no allowlist entry is needed: sh/gh/test-inventory.py only inventories Rust #[ignore] tests, fuzz/bench targets, and recipes, so a Kotlin @Ignore is outside its scope.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Merged via the queue into main with commit 4bbdde2 Nov 10, 2026
6 checks passed
@kixelated
kixelated deleted the test/kt-playout-delay-quarantine branch November 10, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant