Repository navigation
quest: delete opus-stalled-share, Chromium Opus rows pass after #8058 - #8480
Conversation
Quest-Claim: de6df7f73b5ffb7b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe Chromium Opus stalled-share quest document was deleted. Its entry in the Required list and its link in the Related list were removed from the audio jitter target documentation. Merge Risk:
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit 48a5e4a.
Overall direction: No actionable findings. Removing the quest matches its explicit exit condition: the two cited scheduled-run logs both show Chromium Opus rows within budget, with the stated stalled-share values. The separate calibration quest remains, and this changes neither player behavior nor budgets.
Verification limits: GitHub-only diff and existing Actions-log inspection. No new workflows, builds, or tests run; two nights do not establish a long-term flake rate.
There was a problem hiding this comment.
ℹ️ Minor suggestion only. The deletion is sound and I reproduced the evidence; one figure in the PR description is off.
Reviewed changes
Reviewed the complete diff (3 files, 0 additions, 36 deletions): a completed quest is removed along with both of its inbound links.
- Quest deleted —
quest/m1/audio-jitter-target/opus-stalled-share.md, after its own exit condition (Chromium Opus rows pass astalled_sharebudget) was met. - Inbound links removed — the epic's
Requiredentry inquest/m1/audio-jitter-target/README.mdand theRelatedentry inquest/m1/audio-jitter-target/calibrate.md.
I verified the evidence independently. Both cited nightlies exist and postdate #8058's merge: run 42659882487 (2026-11-09T16:57Z, head b3fbce18) and 42842827718 (2026-11-10T15:17Z, head cd560bde). Both ran just test audio-quality --runtimes chromium --enforce, printed within budget for the Chromium step, and their stalled column matches the table. #8459 leaves stalledShare in analyze.ts untouched (window.filter((s) => s.stalled).length / window.length), so the pre-#8459 runs grade the same metric. grep finds no tracked reference to the deleted path left, and the Quest check run on 48a5e4a succeeded.
ℹ️ opus-48000-step is budgeted at 0.022, not 0.01
The evidence table says "Ceiling is 0.01" for every row, and the Choices section says "Step sits at 0.009, close to the ceiling". budgets.json gives chromium/opus/step stalled_share: 0.022, at both graded SHAs as well as on main, so that row passes with more than 2x headroom. The verdict is unchanged (every row is under its own ceiling), but the description overstates how tight step is — bursty at 0.009 against 0.01 is the row that is actually close.
Technical details
# Correct the stalled_share ceiling reported for the step row
## Affected sites
- PR description, Evidence table footer — "Ceiling is 0.01" applies to five of the six rows; `chromium`/`opus`/`step` is 0.022.
- PR description, "Choices made without asking" — "Step sits at 0.009, close to the ceiling" is false at 0.022; the near-ceiling row is `bursty` (0.009 vs 0.01).
## Required outcome
- The description states each graded row's own ceiling, or notes that `step` is budgeted at 0.022, so a later audit does not read `step` as near-failing.
## Suggested approach (optional)
- Change the table footer to "Ceilings are 0.01, except `opus-48000-step` at 0.022" and reference `bursty` in the Choices bullet. `test/audio-quality/budgets.json` is the authority; the ceilings were identical at `b3fbce18` and `cd560bde`.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the delta since the last Pullfrog review (48a5e4a): a merge of origin/main and the resulting narrowing of the diff.
- Merged
origin/main(529fa6ac9) — main had already dropped the epic README's## Requiredand## Relatedsections, so the merge kept main's README untouched and the PR is now a two-file deletion (0 additions, 35 deletions). - Deletion still consistent —
calibrate.mdon main still carried theChromium Opus stalled sharelink this PR removes, andgrep -rn opus-stalled-share quest/finds no dangling reference at4076330. - Prior finding addressed — the description now reads "Ceilings are 0.01, except
opus-48000-stepat 0.022" and namesburstyas the row near its ceiling, matchingtest/audio-quality/budgets.json.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Deletes opus-stalled-share: its own exit condition ("if the rows pass, delete this quest") is met.
Evidence
Scheduled nightlies after moq-dev/moq#8058 merged (2026-11-09T02:20Z), Chromium step reports "within budget" both nights:
Ceilings are 0.01, except
opus-48000-stepat 0.022. Both nights ran before moq-dev/moq#8459 merged (2026-11-10T23:29Z); that PR regrades lag and trims, notstalled_share, so it does not change this verdict. The Audio quality job still fails on other steps (nativetarget_ms_p95, push-to-talk), outside this quest.Choices made without asking
Review
Skipped at head
4076330a669b2234cd97107c105e7b1aeb93fb11: the diff only deletes a quest file and its links, plus a merge of origin/main resolved by taking main's epic README (it already dropped## Required).quest checkandjust checkpass. Pullfrog's ceiling note is fixed in this description; the OpenAI review had no findings.Public API: none. Wire: none.
🤖 Generated with Claude Code
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, XS)
(Written by Claude Opus 5.5 with low)