Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
moq-cli / release / Build (armv7-unknown-linux-gnueabihf)has failed every nightly since armv7 shipped in #8250 (job):E0463 can't find crate for core.dtolnay/rust-toolchaininstalls the armv7 std into the image'sstable(1.99.1), butrust-toolchain.tomlpins 1.98.1, which is what cargo actually runs, and that toolchain never gets the target. The native x86_64 and aarch64 builds pass only because the host std ships with every toolchain.Approach
Replace the action in the Linux build job with
rustup target add "$TARGET"run from the checkout, the same patternandroid.ymluses: rustup resolves the pinned toolchain fromrust-toolchain.tomland adds the target to it.Impact
moqtarball and .deb in nightly and releases.Alternatives
targetsinrust-toolchain.toml: every developer and CI job would download its std.toolchain: 1.98.1on the action: duplicates the pin in another place to keep in sync.Follow-ups
None. Other nightly failures triaged alongside this: Gate cost needs a host with a PMU (hosted ubuntu-24.04 VMs report
No supported events found; the job has never passed), and the aptTemporary failure resolvingerrors were a roughly two hour Azure DNS outage for the Ubuntu archive hosts (apt on the same ubuntu-26.04 image worked at 12:50 UTC the same day and every prior night).Review
Skipped: a one-step workflow change, checked with
just check(zizmor, actionlint, gh tests).(Written by Opus 5.5)