Repository navigation
Conversation
A replacement segment held behind the old tail adds that hold to each arrival, so it does not drag the schedule ahead. A reset (a hole too large to fill, or a rewind) kept the hold, so the clock re-anchored that much late and moq play waited out media that was already live, draining the sink. Back-to-back push-to-talk presses accumulate a hold, so after the first eviction the native player stalled repeatedly and lost utterance heads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nightly's Audio quality job fails
just test push-to-talkwithnative: an utterance did not resume on its head(runs 43041909115 and 42842827718), with 8 native underruns and 8 stalls where it used to have none. It is a regression from moq-dev/moq#8362, not a flake: it reproduces every time locally, the parent commit passes, and that PR's commit fails.Each back-to-back press resumes one delay after the old tail drains, so the replacement segment's
heldgrows by about 250 ms per press. Once the queue behind it passes the age budget, the consumer evicts media, the hole is too large to fill, andplay_audioresets the sink and callsTrack::reset. The reset clears the anchor but keptheld, so the next arrival anchored the clock that much late. Since #8362, media due past the sink's cap waits inplay_audiountil it is due, so the player sat out about 1 s while a fresh 300 ms sink drained. It stalled, evicted again, and repeated, losing the heads of the following presses. Before #8362 that media was written right away, which hid the stale hold.The comfort numbers in the report (median about 32 s, max about 60 s) are correct: they are milliseconds of comfort noise across the 5 s and 60 s mutes.
Approach
Track::resetzeroes the segment'sheld. Media after the break was not held behind any tail, so its arrivals are the live edge again. A unit test insync.rscovers it and fails without the fix.Local
just test push-to-talk: native 0 underruns, 0 stalls, and every utterance resumes on its head (it was 8/8 and failing before the fix).Impact
moq_mux::sync::Track::resetnow also drops the hold behind a tail. Players that reset after a loss re-anchor at the live edge instead of up to the accumulated hold later.Alternatives
Follow-ups
(Written by Opus 5.5)