You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test-lints.test.py stalls just check on a busy host - #8529
sh/rs/test-lints.test.py has a fail-fast test that runs just rs test and sh/rs/nextest.sh against a probe crate across 18 subtests. Its env did not set LOCAL_SUPERVISED, so each nested run went through sh/local.sh and waited on quest gate for host room. On a busy host the test stalled, which stalled just check. Before the fix, the test timed out at 240 s.
Approach
Set LOCAL_SUPERVISED="1" in the test's env, the same way test_clippy_warning_fails_test_build already does. The nested runs execute directly, and the fail-fast behavior under test is unchanged.
This PR also deletes the finished quest file quest/m0/test-lints-hang.md.
Impact
None: no public API or wire change.
Alternatives
Raise the test's timeout. That hides the wait, and the wait still grows with host load.
Make quest gate skip inside tests. That changes gating for every caller, when only this test's nested runs need to skip it.
Follow-ups
None.
Validation
Before the fix: python3 sh/rs/test-lints.test.py timed out at 240 s (EXIT=124).
After the fix: EXIT=0 in 37 s, 2 tests OK.
Under 24 busy-loop processes: EXIT=0 in 27 s.
Most of each time is cargo compiling the probe crate, so these runs show the stall is gone. They are not a speed benchmark.
just check: EXIT=0, run before the quest file was deleted.
just ci on the committed head: EXIT=0 in 378 s, including python3 sh/rs/test-lints.test.py (Ran 2 tests, OK).
Caused by
moq-dev/moq#7844 - added the fail-fast env without LOCAL_SUPERVISED, so its nested runs waited on quest gate
Score: 10/10, The environment override directly addresses the documented stall with minimal scope, preserves the nextest assertions, and matches the existing Clippy fixture; builds and tests were not run, as instructed.
test_fail_fast_environment_reaches_nextest ran its 20 nested
`just rs test` and `sh/rs/nextest.sh` invocations without
LOCAL_SUPERVISED=1, so each one waited on `quest gate` for host room.
On a busy host the script stalled for minutes. Set it as the clippy
probe already does.
Caused by #7844.
Also deletes the finished quest quest/m0/test-lints-hang.md.
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The TestLints fixture now sets LOCAL_SUPERVISED=1 in the environment passed to its subprocesses. The document describing the test-lint stall diagnosis and proposed environment change is removed.
Merge Risk: Minimal · up to 0efbd
This change stops the lint fail-fast test from stalling on busy hosts and leaves the test's behavior otherwise unchanged. No merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: the test-lints.test.py test stalled just check on a busy host. The PR sets LOCAL_SUPERVISED="1" in that test's env so nested runs skip quest gate, which fixes the stal…
Description check
The description explains the problem (the fail-fast test lacked LOCAL_SUPERVISED, so nested runs waited on quest gate on a busy host), the approach (set LOCAL_SUPERVISED="1" in the test env), the dele…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the test-lints.test.py test stalled just check on a busy host. The PR sets LOCAL_SUPERVISED="1" in that test's env so nested runs skip quest gate, which fixes the stall. The title is specific and matches the changeset.
Full details: Description check
Explanation
The description explains the problem (the fail-fast test lacked LOCAL_SUPERVISED, so nested runs waited on quest gate on a busy host), the approach (set LOCAL_SUPERVISED="1" in the test env), the deletion of quest/m0/test-lints-hang.md, validation runs, and the causing PR. It directly describes the changeset.
Finishing Touches
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 45c1775f-57e4-49c0-8559-f8e3357a4f87
Commits
Reviewing files that changed from the base of the PR and between 4262a06 and 0efbd65.
Files selected for processing: 2
quest/m0/test-lints-hang.md
sh/rs/test-lints.test.py
Files with no reviewable changes: 1
quest/m0/test-lints-hang.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sh/rs/test-lints.test.pyhas a fail-fast test that runsjust rs testandsh/rs/nextest.shagainst a probe crate across 18 subtests. Its env did not setLOCAL_SUPERVISED, so each nested run went throughsh/local.shand waited onquest gatefor host room. On a busy host the test stalled, which stalledjust check. Before the fix, the test timed out at 240 s.Approach
Set
LOCAL_SUPERVISED="1"in the test's env, the same waytest_clippy_warning_fails_test_buildalready does. The nested runs execute directly, and the fail-fast behavior under test is unchanged.This PR also deletes the finished quest file
quest/m0/test-lints-hang.md.Impact
None: no public API or wire change.
Alternatives
quest gateskip inside tests. That changes gating for every caller, when only this test's nested runs need to skip it.Follow-ups
None.
Validation
python3 sh/rs/test-lints.test.pytimed out at 240 s (EXIT=124).just check: EXIT=0, run before the quest file was deleted.just cion the committed head: EXIT=0 in 378 s, includingpython3 sh/rs/test-lints.test.py(Ran 2 tests, OK).Caused by
LOCAL_SUPERVISED, so its nested runs waited onquest gateModels
Size: XS
Implementer: Claude, claude-haiku-5-5, xhigh effort
🤖 Generated with Claude Code
(Written by Claude Haiku 5.5 with xhigh effort)
Review
Rewritten by
quest reviewafter each round.01a1cd6a-dadc-7161-8892-0481f2153ebd, round 1The environment override directly addresses the documented stall with minimal scope, preserves the nextest assertions, and matches the existing Clippy fixture; builds and tests were not run, as instructed.