Repository navigation
docs(quest): plan decision inbox follow-ups - #146
Conversation
Add webhook reconcile, inbox merge, and co-maintainer membership quests to the kix epic, and fold the unread badge into mobile and the runner settings page into runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca4a791ba2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Any failed maintainer check drops that user's membership along with their | ||
| read and skip state for the project. The enrolling user is a member like |
There was a problem hiding this comment.
Preserve membership when authority cannot be checked
When GitHub is temporarily unavailable or rate-limits either API call in GitHubService.#maintainer, the check fails without proving that the user lost access. Treating any such failure as revocation would permanently delete the membership and its read/skip state, hide the project from the user's inbox, and require them to rediscover the project manually. Only an authoritative permission denial should remove membership; transient or indeterminate failures should fail the request without deleting state.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. fee6f91 drops membership only when GitHub answers the check with a denial; an outage or rate limit fails the request and leaves membership and read/skip state alone. Added a rate-limited case to the tests.
(Written by Claude Opus 5.5)
…omplete Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
(Written by Claude Opus 5.5) |
Drop the deleted prompts quest from the follow-up quests #146 added, and remove their now-empty Required sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
This plans the follow-ups suggested by the decision inbox PR (#144):
quest/m0/kix/reconcile.md: after each webhook, reconcile the project in the background with the installation token, so new items arrive ready to act on.quest/m0/kix/merge.md: a merge button on PR items, bound to the head SHA the maintainer saw. It reuses the merge-method selection from bot publication.quest/m0/kix/members.md: a maintainer joins a project's inbox once they pass its maintainer check, and drops out on any failed check.mobile.md.runner.md.All three new quests require
quest/m0/kix/prompts.md, andmerge.mdalso requiresquest/m0/kix/publication.md. #144 and #145 delete those files, so whichever PR merges second must update theRequiredlinks.Planning decisions
Co-maintainers: how should a project reach a maintainer's inbox besides the one who enrolled it?
Merging from the inbox: where does the PR-item merge button live?
Scale: new issues show as "Issue #N" until someone refreshes, and each inbox load makes about 5 GitHub calls per project. What do we plan?
Nav unread badge and runner settings page: new quests, or fold them into existing ones?
mobile.mdand the settings page intorunner.md.Revocation: what happens to a member's membership when they later fail the maintainer check?
Rank: what priority do the three new quests get in the kix epic's
Requiredlist?Checks
quest check,just checkandjust testpass.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)