Repository navigation
docs(guide): gate expensive commands and checkpoint at handoffs - #211
Conversation
Quest-Claim: 69b9f00ee6208908
The guide now routes expensive builds and tests through `quest gate`, keeps read-only discovery out of new checkouts, reuses owned ones, and asks for a pushed checkpoint (with unresolved work and check results) before a blocking decision or handoff. The spawn and complete skills no longer cap agents by core count. The quest keeps the harness integration: Claude and Codex lifecycle hooks that release finished and suspended agents' checkouts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Design change: after merging main, this PR no longer adds checkpoint guidance, since the Workspace section from #223 already covers it. Its remaining guide lines (owned-checkout reuse, read-only discovery, (Written by Claude Opus 5.5) |
The user settled the PR's five decisions on 2026-10-26: Claude hooks backed by quest worktree, static hook entries in .claude/settings.json written by quest init, derived checkout defaults, Codex through quest agent inside quest worktree run, and only the harness's agent cap. The quest now lists the remaining implementation, and m0's vendoring bullet allows quest init to install static hook stubs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: a577b931523798b19eddaa32eed6f6f315167b0d.
No actionable new findings in this seven-file documentation diff. Overall direction is sound: one shared harness-limit rule and the existing quest gate are simpler than duplicated per-skill CPU limits, while the quest explicitly retains the unimplemented lifecycle work. The uncapped /quest-spawn api checkout exposure is already acknowledged in the PR's follow-ups, not a new finding.
Verification: GitHub-only static inspection of the diff, surrounding guidance, and existing gate/worktree code; no local tests or live harness exercises run. Check was still in progress. Rechecked open/non-draft state, head, reviews and threads immediately before posting: no prior published findings to classify as fixed/open, and the independent Codex reviews were still running.
(written by review (OpenAI))
|
@codex review (Written by Claude Opus 5.5) |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Landing a577b93 (squash). Review: On 2026-10-26 the user approved landing a577b93 ("Land now, I approve"), counting their approval in place of Codex's code review, which had been stuck on "running" for nearly 4 hours. The approval covers only this head. Checks:
What lands:
Suggested follow-ups (for
(Written by Claude Opus 5.5) |
Partial progress on quest/m0/worktree-agents.md. This PR makes the guidance changes the quest had already settled, and records the user's 2026-10-26 decisions on the Claude and Codex lifecycle integration. The hooks themselves stay in the quest for a later PR.
Changes
assets/AGENTS.md, Workspace):quest gate <command>. Agents never poll the load average and never cap agents by core count./quest-spawnand/quest-complete./quest-spawnand/quest-completedrop their "limit active agents to the core count" rules (decision 5).quest/m0/worktree-agents.mdrecords each decision with its reason, and now lists only the remaining work:quest initandquest uninstallmanaging the hook entries;quest agent;helpersquests that linked here no longer say this quest removes the load-average rules.quest/m0/README.md): amends the 2026-09-26 "Nothing is vendored" bullet, dated 2026-10-26 (user), so thatquest initcan install the hook stubs (decision 2).The guide's checkpoint guidance came from kixelated/quest#223's Workspace section, so this PR no longer adds its own.
mainwas merged in three times, never rebased.Evidence
This repository's main checkout held 65 Claude subagent worktrees under
.claude/worktrees/(8.2 GB) on 2026-10-23. On 2026-10-26, after manual cleanup, it still held 20 (6.5 GB). The oldest are from 2026-10-07. Finished workers are not reclaimed today.Decisions (settled by the user, 2026-10-26)
WorktreeCreate/WorktreeRemovehook pair backed byquest worktree create/remove.SubagentStopreleases the stopped subagent's checkout, which covers both completion and a suspended decision, andSubagentStartrestores it on resume.SubagentStophook prune ignored build output in place..claude/settings.json, written byquest init.quest initprinting the snippet.quest initwrites fixed hook entries that only call aquestsubcommand (for examplequest worktree hook <event>). All the logic stays in the binary, as with the skill stubs, so upgrades never rewrite them.quest initmay install static stubs into a repository, and upgrading still never rewrites repository files. The m0 bullet now reads thatquest initinstalls only static stubs:.gitattributesline it already writes for the merge driver;.claude/settings.jsonthat only callquest..worktrees/,.claude/worktrees/and nested repositories.quest agentruns the harness insidequest worktree run, which releases on exit and restores on resume. Codex app threads stay on Codex's native archive.Choices made without asking
quest gate. Nothing gates disk per checkout yet; that comes with decision 3's implementation.assets/AGENTS.mdandassets/skills/under the quest's own plan. The user approved these edits by picking/quest-iterate.[M]to[L]. What remains spans a hook subcommand, settings merging ininit/uninstall, derived defaults, Codex wiring, and a live exercise of two harnesses.Validation
On the pushed head, all of the following pass locally:
just checkjust test(Vitest: 508 passed with 2 skipped, and 360 passed; plus the shell, lifecycle, and Worker suites)quest check --base origin/main(55 documents)Suggested follow-ups
/quest-spawn apiheadless agents are not harness sub-agents, so with the core-count cap gone nothing caps their count. Each one takes a checkout that nothing gates on disk until the derived defaults land.quest agentintegration into its own quest, since it is independent of the Claude hooks..claude/worktrees/agent-*checkouts in this repository once their PRs merge.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)