Skip to content

quest: plan follow-ups from the 2026-10-24 merge wave - #220

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/followups-1024
Oct 25, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/followups-1024

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans the follow-ups reported by the 2026-10-24 /quest-spawn and /quest-complete wave, which merged #202–#210 and #212–#219.

New quests

m0

  • quest/m0/ci-flakes.md [M]: native Windows test flakes (gate headroom count, 5 s timeouts) and Release's macOS queue timeout
  • quest/m0/review-policy.md [XS]: CONTRIBUTING.md says whose review counts
  • quest/m0/helpers/landing.md [S]: quest merge --land refuses a stale head; ask on a missing required review; one design-checkpoint definition
  • quest/m0/helpers/wait-accuracy.md [S]: wake on edited bot comments, honest checks:passed, review rounds in quest status
  • quest/m0/kix/context-pages.md [S]: page every list in the context read
  • quest/m0/kix/merge-holds.md [S]: sweep for ended merge jobs' holds, one shared hold rule
  • quest/m0/kix/sandbox.md → epic quest/m0/kix/sandbox/README.md (via quest mv), children in order: claude-pin [XS], trust [M], opencode [M], macos [M], apparmor [S], vm [L]
  • The kix epic's end-to-end test adds a merge job; its live rehearsal adds the workflows-refusal check from Land picked PRs through merge jobs #209

m1

  • quest/m1/merge-jobs.md [M], quest/m1/inbox-polish.md [M], quest/m1/worker-dev.md [S], quest/m1/resolve-tuning.md [S]

quest check and just check pass.

Decision paper trail

Round 1: which follow-ups to plan

  • CLI and skills: ✅ Windows test flakes · ✅ Merge landing rules · ✅ wait/status/merge fixes · ✅ quest resolve tuning
  • kix: ✅ Merge-job hardening · ✅ Page context reads · ✅ Inbox polish · ✅ Dev/test infra
  • Split sandbox.md? ✅ Split into an epic · Keep one quest
  • Write the review policy into CONTRIBUTING.md? ✅ Plan a quest · Drop

Round 2: placement

  • Which go to m1? ✅ Inbox polish · ✅ Dev/test infra · ✅ quest resolve tuning · ✅ Merge-job extensions
  • Merge-job hardening: ✅ Split by purpose (m0 merge holds; seeded merge job into the e2e test; workflows refusal into the live rehearsal; extensions in m1) · One m0 quest
  • Smaller leftovers to keep: ✅ Claude Code pin bump · ✅ Release macOS queue · Read-only registries (dropped) · Cancellable fetch (dropped)
  • Dispatch "Check release installs" for v0.1.0? ✅ Run it now · Wait for the next release. Result: run 40144909978. All macOS and Linux installs pass with mise-action 5.2.0. The Windows installs fail because v0.1.0 has no Windows assets, which predates native Windows support.

Round 3: design

  • Whose review counts: Codex no-findings counts · ✅ Only posted reviews · Human after hand merges
  • Catching textually clean merges that break tests: ✅ quest merge refuses stale · Skill prose only · Require up-to-date
  • Gate test fix: ✅ Assert the invariant · Fix the gate
  • Sandbox order: ✅ pin bump, trust, opencode, macOS + lift gate, AppArmor, VM devShells · macOS first · VM devShells first

Round 4: last details

  • Who removes quest:merge after a merge? Release on merge · ✅ Leave it (cosmetic; holds only count on open PRs)
  • Fold the macOS queue timeout into the CI flakes quest? ✅ One quest · Separate
  • Create the tree as proposed? ✅ Create it · Adjust first

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Split the job sandbox into an epic of six children, and add quests for CI
flakes, the review policy, landing rules, wait/status accuracy, merge holds,
context paging, and four m1 follow-ups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T00:32:26.946335Z 5abf481 New commits
🔒 Security Review ✅ Completed 2026-10-25T00:33:12.495315Z 5abf481 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7b87de50e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m0/kix/sandbox/trust.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Codex's P1 finding on quest/m0/kix/sandbox/trust.md was correct: commit authorship can be forged through the author email. Fixed in 5abf481. Trust now requires authenticated provenance: a commit counts as a maintainer's only with a GitHub-verified signature for that maintainer's account, and as a kix job's only when kix recorded the push. Unsigned and forged-author commits are now test cases. This keeps the recorded decision that trusted heads have commits from maintainers or kix jobs only, and it changes how that is checked.
  • Codex gave 👍 on head 5abf481 with no findings. All checks pass, and quest check --base origin/main passes from a base build.
  • Landing with a squash merge. Main has not moved since the branch was cut.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 42c49e8 into main Oct 25, 2026
4 checks passed
@kixelated
kixelated deleted the quest-plan/followups-1024 branch October 25, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant