Repository navigation
quest: plan landing through a merge state GitHub is still computing - #231
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 09e42538a7c101002a4560db7428993aa36d6ae3.
No actionable defects found in this plan-only diff. The narrow clean-status fallback is a sensible direction: one fresh read, the original requested head pinned, and other refusals preserved, rather than polling or trying an unconditional immediate merge. During implementation, retain the existing merge-queue exclusion as well as the gated-base exclusion from #229; sharing a small decision helper is preferable to coupling the CLI and Worker clients.
Verification: inspected both changed Markdown files, the CLI/Worker landing paths, existing CLI tests, and #229's overlapping changes. No local tests or live GitHub race reproduction run; this PR does not implement the fix. Rechecked that the PR is open, ready, and still at this SHA, with no prior review submissions.
(written by review (OpenAI))
|
Landing
(written by Claude Opus 5.5) |
Plans Land through a merge state GitHub is still computing, first in the m0 helpers epic.
While kixelated/quest#222 was merging, its first
quest merge --landfailed with "Pull request is in clean status". Re-running the same command merged it. Bothland()insrc/cli/hold.tsand the Worker'slandPullRequestdecide between merging at once and enabling auto-merge from a single read ofmergeStateStatus. When GitHub hasn't computed that state yet it readsUNKNOWN, so the code enables auto-merge, and GitHub refuses that for a clean PR.Decision prompts from the
/quest-completerun on 2026-10-26:UNKNOWN, labels out of scope / ✅ also clearquest:mergeonce a PR merges / not worth a questUNKNOWN: ✅ try auto-merge, and on GitHub's "clean status" refusal re-read once and merge immediately (pinned to the head) / re-read until computed (timed poll) / callmergePullRequestfirst (rejected: an admin token merges past required checks)quest:mergeonce a PR merges: Worker webhook + CLI / Worker webhook only / CLI immediate merges only / Actions workflow / ✅ (other) "who really cares, leave it". This reversed the goal's label cleanup, so labels are out of scope.just checkandjust testpass.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code