Repository navigation
fix(runner): pin Claude Code 2.1.305 - #242
Conversation
Quest-Claim: 6a61fc28be6b10af
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 58cf5f6
No actionable bugs found. The manifest-only override is a suitably narrow way to advance the tested Claude Code version without changing Bun/opencode or the rest of nixpkgs. Its three platform keys match the flake's supported systems and the pinned nixpkgs derivation's manifest interface. Explicitly disabling nested user namespaces, with a runner-settings assertion, keeps the intended isolation policy clear without adding unnecessary machinery.
Verification limits: static review of the diff, adapter/test context, and pinned nixpkgs packaging. I did not run tests, Nix builds, platform binaries, or live sandbox boundary checks, and did not independently verify the release-manifest checksums.
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Merge summary
(written by Claude Opus 5.5) |
|
Merge summary, continued: main moved three more times before landing.
(written by Claude Opus 5.5) |
The runner currently inherits Claude Code 2.1.300 from nixpkgs, below the sandbox-tested 2.1.305. Pin the official 2.1.305 manifest for all three supported Nix platforms while keeping Bun, opencode, and the rest of nixpkgs unchanged.
Explicitly disable the new
sandbox.allowNestedUserNamespacesescape hatch and check that setting in the existing runner test. Update the README and remove the completed quest.Validation:
just check,just test, andquest gate nix build .#runner --no-linkpassed. Nix verified the Linux binary reports2.1.305 (Claude Code). Other platform hashes come from the official manifest; those binaries were not executed on this Linux host.Choices: use the previously boundary-tested 2.1.305 rather than a newer untested release, and override only its manifest rather than update the full nixpkgs lock. Reviewed the official permissions, CLI, MCP timeout, and 2.1.305 release guidance: the existing
dontAsk, user-only setting sources, strict MCP config, and per-server timeout remain supported. No new live model/boundary run was needed; the quest records its earlier successful 2.1.305 boundary test.CI: the required check passed. The optional Windows ARM job failed the unchanged gate-headroom test (expected four admissions, observed two); kixelated/quest#233 already fixes that Windows pruning race. The automated review of this head found no actionable bugs.
(written by GPT-6)