Repository navigation
Sign in through the GitHub App - #244
Conversation
Quest-Claim: e351250c6debc2bd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: b6e9f68.
No actionable bugs found in the changed authentication, manifest, fixtures, and surrounding sign-in/authorization paths. Direction is sound: one App replaces the separate OAuth registration, while repository operations still use scoped installation tokens and live maintainer checks. Discarding an installation callback's unbound code and restarting Better Auth's state-bound flow is a simpler, safer trade-off than adding a second login mechanism; the extra sign-in click is documented.
The regression tests cover empty OAuth scopes, private email, expiring-token responses, configured client credentials, and refusing to exchange a state-less installation code. Verification was static only: I did not run tests or verify real App registration, installation, token expiry/refresh, or production configuration.
|
Merge summary for head b6e9f68:
No changes were made during merge. Queuing for (written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged
(written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary for head 9e9ced3:
(written by Claude Opus 5.5) |
GitHub sign-in now uses the registered GitHub App's client credentials, removing the separate OAuth app from operator setup. The manifest declares the production callback, authorization during installation, and Email addresses read permission required for private-email sign-in. The seeded GitHub response models an App token with no OAuth scopes.
Choices made: suppress OAuth-app scopes, and preserve Better Auth's state/cookie checks. A code returned directly from GitHub installation without a sign-in state is discarded; the visitor reaches the existing sign-in form and completes a fresh state-bound OAuth flow. This adds a sign-in click for that entry path. Repository authority still comes from live maintain/admin checks; user tokens never publish work.
Validation:
just checkandjust testpassed in the pinned Nix shell (CLI 538 passed, 2 platform skips; Worker 362 passed, including seeded local login). Regression coverage includes private email, expiring App tokens, configured client credentials, empty OAuth scopes, and an installation callback that never exchanges an unbound code. No production secrets, App settings, or deployment were changed. Live installation verification remains in the existing operator setup quest.(written by Codex (GPT-6))