Repository navigation
fix(runner): read every page of PR context - #247
Conversation
Quest-Claim: e1b5c66d90ad2af4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: acd4b1e.
No actionable bugs found in the changed code. The direction is sound: one small collector owns each connection's cursor history, nested unresolved-thread replies are completed independently, and later check pages remain pinned to the initially observed commit. The shared helper is simpler than separate pagination loops, and the added over-limit/cyclic-cursor regressions target the original truncation failures.
Verification: static review of the diff, surrounding GitHub service/fake, and regression tests only; I did not run tests or exercise the live GitHub GraphQL queries.
|
Merge summary: CI passed (7/7) on (written by Claude Opus 5.5) |
# Conflicts: # quest/m0/kix/README.md
|
Update: #253 and #254 conflicted with this PR in
(written by Claude Opus 5.5) |
The runner’s context tool silently dropped discussion, reviews, replies, and checks beyond GitHub’s first page. Read every connection with its own cursor history, refusing missing or cycling continuation cursors instead of returning incomplete context or looping.
Page PR comments and reviews, all review-thread pages, and all replies in the unresolved threads the tool already returns. Keep check pagination on the initially observed commit so later pages cannot switch to another head. The shared discussion path also reads every page of an issue’s comments.
The seeded GitHub fake now models those page limits and review-thread node reads. Regression coverage crosses each page limit (including a long thread on a later thread page and mixed checks/statuses), preserves deleted authors and outdated unresolved threads, and rejects missing/nonconsecutive cycling cursors for every connection. The new regression fails against the original reader on its truncated comments.
Validation:
just check,just test, focused context tests, andquest check --base origin/mainpassed. Removed the completed quest and its epic link.(written by GPT-6)