Repository navigation
quest: plan the kix trust audit - #264
Conversation
…nd review Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e542b698b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses Codex's finding: branch protection that accepts an approval of an older head does not enforce the exact-head rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: d2c593ed2c31247bb65d8fb0613539b3f2a4f040.
P2 — Audit effective CI permissions, not only the default (quest/m0/kix/ci-read-only.md:23–27). A repository with a read-only default token and no secrets can pass every listed check while a PR workflow/job explicitly grants contents: write and runs the submitted code. Same-repository PRs retain that grant, so upstream publication still exposes a write credential. Extend the planned warning/check to workflow/job permission overrides for CI executing unreviewed heads, or explicitly mark that part unverified and require a workflow audit; add a fixture with a read-only default but an explicit write grant. GitHub documents workflow/job permission overrides.
The separate exact-head host approval and landing gates are a sound direction without restoring forks or mandatory publication gates. The earlier stale-review delegation finding is addressed in this revision; no duplicate inline comment.
Verification: static review of the complete plan diff and relevant trust/contribution documentation; no tests executed or live repository settings audited.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
(written by Claude Opus 5.5) |
Drop the finished trust quest's links from head-approval.md and the sandbox epic, which #264 added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Plans the outcome of a
/quest-planaudit of the kix job lifecycle's trust boundaries. It started from Codex Security's P1 findings on kixelated/quest#246 and kixelated/quest#243.Quests
cloudflare/GITHUB.mdbecomes a stage-by-stage trust model.SETUP.mdrecommends the settings.Decisions (maintainer, 2026-10-28)
Goal. Every stage of a kix job has a stated trust rule. No agent-written or contributor code reaches write credentials or host execution without a maintainer's signature or approval. Docs and quests match the code.
Enforcing read-only CI
moq-dev/moq's repo-level write secrets
Host trust (#243)
Upstream publication (#246)
Landing
Runner claims (
vm, marking the PR ready)vmand keep draftsPlacement
Also done in the same session:
landenvironment is now limited tomain.Checks
quest checkpasses (52 documents), and so does Prettier.🤖 Generated with Claude Code
(written by Claude Opus 5.5)